Skip to content

fix: Fix integration test error in test_default_right_size_and_deploy_unregistered_base_model #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

SSRraymond
Copy link
Contributor

@SSRraymond SSRraymond commented Mar 8, 2023

Issue #, if available:

Description of changes:
Integration test is failing, fix to make it successful.

Testing done:
Ran tox tests/integ/test_inference_recommender.py::test_default_right_size_and_deploy_unregistered_base_model and the tests is successful.

Screenshot 2023-03-07 at 4 07 57 PM

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SSRraymond SSRraymond requested a review from a team as a code owner March 8, 2023 00:09
@SSRraymond SSRraymond requested review from claytonparnell and removed request for a team March 8, 2023 00:09
@navinsoni navinsoni merged commit 9e5dca6 into aws:master Mar 8, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@SSRraymond SSRraymond deleted the fix branch November 30, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants