Skip to content

fix: make RemoteExecutor context manager non-blocking on pending futures #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

fix: make RemoteExecutor context manager non-blocking on pending futures #3822

merged 1 commit into from
May 3, 2023

Conversation

nmadan
Copy link
Member

@nmadan nmadan commented Apr 27, 2023 •
edited
Loading

Issue #, if available:

Description of changes: Right now, the RemoteExecutor context manager blocks on all pending futures completing. This is not the intended behavior. This change makes it non-blocking by changing the value of wait parameter provided to ThreadPoolExecutor.shutdown() https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Executor.shutdown

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nmadan nmadan requested a review from a team as a code owner April 27, 2023 19:53
@nmadan nmadan requested review from mufaddal-rohawala and removed request for a team April 27, 2023 19:53
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 8f98134
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 8f98134
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 8f98134
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 8f98134
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 8f98134
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: d9047f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: d9047f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: d9047f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: d9047f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #3822 (d9047f8) into master (20cffd6) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
- Coverage   89.89%   89.15%   -0.74%     
==========================================
  Files        1060      247     -813     
  Lines      101188    25042   -76146     
==========================================
- Hits        90962    22326   -68636     
+ Misses      10226     2716    -7510
Impacted Files Coverage Δ
src/sagemaker/remote_function/client.py 96.86% <100.00%> (ø)

... and 1306 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: d9047f8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: d9047f8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell claytonparnell merged commit 5f40087 into aws:master May 3, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request May 5, 2023
Revert "fix: make RemoteExecutor context manager non-blocking on pend…
7eca440 
…ing futures (aws#3822)"

This reverts commit 5f40087.
@nmadan nmadan mentioned this pull request May 5, 2023
Merged
9 tasks
knikure pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request May 12, 2023
@knikure
Revert "fix: make RemoteExecutor context manager non-blocking on pend…
5cd7537 
…ing futures (aws#3822)"

This reverts commit 5f40087.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatro dpatro dpatro approved these changes

@rohangujarathi rohangujarathi rohangujarathi approved these changes

@claytonparnell claytonparnell claytonparnell approved these changes

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala mufaddal-rohawala is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nmadan @sagemaker-bot @codecov-commenter @dpatro @rohangujarathi @claytonparnell