feat: Add support for Deployment Recommendation ID in model.deploy() #3897

gwang111 · 2023-06-02T16:48:53Z

Issue #, if available:
The Inference Experience Team has launched a new feature called Deployment Recommendation that can be retrieved from the DescribeModel API. Provide PythonSDK support for deployment via Deployment Recommendation ID

See: #3695

Description of changes:

within inference_recommender_mixin -> provided support for Deployment Recommendation ID
add tagging support for inference recommender
add requisite unit tests
add requisite integ tests

Testing done:

unit testing of IR mixin
unit testing of deploy
integ test for Deployment Recommendation ID

dev-dsk-garywansde-2a-097fc889 % aws sagemaker list-tags --resource-arn arn:aws:sagemaker:us-west-2:079808353510:endpoint/test-rec-id-deployment-default-sklearn-1686010938-2035
{
    "Tags": [
        {
            "Key": "ClientType",
            "Value": "PythonSDK-DeploymentRecommendation"
        }
    ]
}

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knikure · 2023-06-05T16:21:37Z

@gwang111 Is there a reason why you created this PR if already a PR exists for the same change? Is that a PR which needs to go first?

sagemaker-bot · 2023-06-06T00:52:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4f4e753
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T01:27:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4f4e753
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T01:36:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4f4e753
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T01:52:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4f4e753
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T02:19:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4f4e753
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T15:56:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5d97eb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

gwang111 · 2023-06-06T15:58:01Z

@gwang111 Is there a reason why you created this PR if already a PR exists for the same change? Is that a PR which needs to go first?

Hey @knikure yea so to clarify, we are adding tagging for two services. The one we merged yesterday was just for create_inference_recommendations_job tagging. This one is adding tagging for deployment recommendations in the create_endpoint API

sagemaker-bot · 2023-06-06T16:30:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5d97eb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T16:44:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5d97eb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T16:46:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5d97eb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T16:57:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e735e3f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T17:13:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e6ee819
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T17:52:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 36d87ec
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T17:57:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 36d87ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T18:03:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 36d87ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T18:27:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36d87ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T18:30:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 36d87ec
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-06T18:57:10Z

Codecov Report

Merging #3897 (5ec2f4a) into master (f1a809c) will decrease coverage by 0.73%.
The diff coverage is 91.22%.

❗ Current head 5ec2f4a differs from pull request most recent head 12da15a. Consider uploading reports for the commit 12da15a to get more accurate results

@@            Coverage Diff             @@
##           master    #3897      +/-   ##
==========================================
- Coverage   90.08%   89.36%   -0.73%     
==========================================
  Files        1156      271     -885     
  Lines      106700    26394   -80306     
==========================================
- Hits        96121    23587   -72534     
+ Misses      10579     2807    -7772

Impacted Files	Coverage Δ
...ference_recommender/inference_recommender_mixin.py	`93.53% <90.90%> (ø)`
src/sagemaker/model.py	`93.78% <100.00%> (ø)`

... and 1425 files with indirect coverage changes

sagemaker-bot · 2023-06-06T21:00:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e5f5865
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T21:12:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e5f5865
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T21:13:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e5f5865
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-06T23:27:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e5f5865
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

gwang111 · 2023-06-07T16:15:35Z

@gwang111 Is there a reason why you created this PR if already a PR exists for the same change? Is that a PR which needs to go first?

Hey @knikure yea so to clarify, we are adding tagging for two services. The one we merged yesterday was just for create_inference_recommendations_job tagging. This one is adding tagging for deployment recommendations in the create_endpoint API

Hey sorry @knikure misunderstood the question. If you're asking why we recreated #3695. This is because Jinpeng is no longer with the team and we needed to add integration tests and tagging to his PR

sagemaker-bot · 2023-06-07T16:41:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5ec2f4a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-07T16:51:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5ec2f4a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-07T16:51:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5ec2f4a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-07T17:18:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5ec2f4a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-07T19:30:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5ec2f4a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-08T19:49:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 12da15a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-08T20:00:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 12da15a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-08T20:00:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 12da15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-08T20:30:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 12da15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-08T20:31:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 12da15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

gwang111 · 2023-06-09T00:38:03Z

tagging is delayed so decouping

sagemaker-bot · 2023-06-09T23:45:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 12da15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

gwang111 requested a review from a team as a code owner June 2, 2023 16:48

gwang111 requested review from knikure and removed request for a team June 2, 2023 16:48

gwang111 force-pushed the jinpeng_deployment_rec branch from b9df243 to 3c5203d Compare June 2, 2023 16:49

knikure self-assigned this Jun 5, 2023

knikure changed the title ~~feat: add support for Deployment Recommendation ID in model.deploy()~~ feat: Add support for Deployment Recommendation ID in model.deploy() Jun 5, 2023

gwang111 force-pushed the jinpeng_deployment_rec branch from 4eaf92b to 4f4e753 Compare June 6, 2023 00:48

gwang111 force-pushed the jinpeng_deployment_rec branch from 4f4e753 to 5d97eb6 Compare June 6, 2023 15:51

gwang111 force-pushed the jinpeng_deployment_rec branch from e5f5865 to 5ec2f4a Compare June 7, 2023 16:02

jinpengqi and others added 11 commits June 8, 2023 12:07

Add deployment support for instant recommendations

3fc0317

Refactor get_recommendation

11468fa

Modify to check recommendations job res first.

46fa4b7

Update exception msg

104135a

add tags for inf and dep recommendations

eaa41b1

Code Formatting

a64aea6

remove hardcoded tag

13ab6a4

add doc string and fix unit tests

a629ef8

formatting

c183ed0

integ test formatting

8989846

update model package tests

12da15a

gwang111 force-pushed the jinpeng_deployment_rec branch from 5ec2f4a to 12da15a Compare June 8, 2023 19:07

gwang111 closed this Jun 9, 2023

gwang111 reopened this Jun 9, 2023

gwang111 closed this Jun 9, 2023

feat: Add support for Deployment Recommendation ID in model.deploy() #3897

feat: Add support for Deployment Recommendation ID in model.deploy() #3897

Uh oh!

Conversation

gwang111 commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

knikure commented Jun 5, 2023

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

gwang111 commented Jun 6, 2023

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 6, 2023

AWS CodeBuild CI Report

Uh oh!

gwang111 commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gwang111 commented Jun 2, 2023 •

edited

Loading

codecov-commenter commented Jun 6, 2023 •

edited

Loading

gwang111 commented Jun 7, 2023 •

edited

Loading