feature: model registry integration to model cards to support model packages #3933

shrestha-bikash · 2023-06-15T00:07:13Z

Issue #, if available:
https://issues.amazon.com/issues/f3562ffe-a316-413d-8b44-19f28a8d8cf8

Description of changes:
Feature to support model registry's model package association into model cards. This feature facilitate user to associate model package using ModelPackage class and its helper methods. User need to provide the ARN of the model package and this feature will auto discover model package metadata information as well as training details and evaluation job details associated to that model package which will get auto populated into model card.

Testing done:
Unit testings added
Integration testings added

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ackages * patched the changes from staging repo: https://github.com/aws/sagemaker-python-sdk-staging/tree/master-model-registry

sagemaker-bot · 2023-06-15T00:45:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dae8996
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-15T00:55:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dae8996
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-15T01:13:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dae8996
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-15T01:23:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dae8996
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-15T01:32:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dae8996
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-15T01:34:35Z

Codecov Report

Merging #3933 (a20b094) into master (c1b2465) will decrease coverage by 0.71%.
The diff coverage is 87.93%.

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
- Coverage   90.30%   89.59%   -0.71%     
==========================================
  Files        1292      305     -987     
  Lines      112984    28177   -84807     
==========================================
- Hits       102031    25246   -76785     
+ Misses      10953     2931    -8022

Impacted Files	Coverage Δ
src/sagemaker/model_card/__init__.py	`100.00% <ø> (ø)`
src/sagemaker/model_card/model_card.py	`90.81% <87.14%> (ø)`
.../sagemaker/model_card/evaluation_metric_parsers.py	`91.66% <88.88%> (ø)`
src/sagemaker/model_card/helpers.py	`92.70% <88.88%> (ø)`
src/sagemaker/model_card/schema_constraints.py	`100.00% <100.00%> (ø)`

... and 1592 files with indirect coverage changes

src/sagemaker/model_card/model_card.py

tests/integ/test_model_card.py

sagemaker-bot · 2023-06-26T22:57:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ffe89e5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T22:59:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ffe89e5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T23:14:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ffe89e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T23:28:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ffe89e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T23:45:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ffe89e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T20:53:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T20:59:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:07:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:15:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:15:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:21:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:55:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T21:55:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T22:11:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-27T22:13:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shrestha-bikash · 2023-06-28T23:35:27Z

/bot run pr

mufaddal-rohawala

/bot run slow-tests, pr, notebook-tests

sagemaker-bot · 2023-06-29T00:29:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T00:29:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run notebook-tests

mufaddal-rohawala · 2023-06-29T00:34:50Z

Notebook tests can be considered a success for this PR, looking at last 2 runs, can override if the last retry still fails.

sagemaker-bot · 2023-06-29T01:10:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a20b094
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T03:23:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a20b094
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feature: model registry integration to model cards to support model p…

dae8996

…ackages * patched the changes from staging repo: https://github.com/aws/sagemaker-python-sdk-staging/tree/master-model-registry

shrestha-bikash requested a review from a team as a code owner June 15, 2023 00:07

shrestha-bikash requested review from mufaddal-rohawala and removed request for a team June 15, 2023 00:07

Zhenshan-Jin approved these changes Jun 15, 2023

View reviewed changes

knikure assigned mufaddal-rohawala Jun 19, 2023

mufaddal-rohawala requested changes Jun 23, 2023

View reviewed changes

mufaddal-rohawala marked this pull request as draft June 23, 2023 17:42

change: resolved review feedback

ffe89e5

Merge branch 'aws:master' into feature-model-registry-integration

a20b094

mufaddal-rohawala marked this pull request as ready for review June 27, 2023 20:36

mufaddal-rohawala approved these changes Jun 27, 2023

View reviewed changes

mufaddal-rohawala reviewed Jun 28, 2023

View reviewed changes

mufaddal-rohawala reviewed Jun 29, 2023

View reviewed changes

mufaddal-rohawala merged commit 0bc4f41 into aws:master Jun 29, 2023

feature: model registry integration to model cards to support model packages #3933

feature: model registry integration to model cards to support model packages #3933

Uh oh!

Conversation

shrestha-bikash commented Jun 15, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 27, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 15, 2023 •

edited

Loading