Skip to content

fix: Update apache airflow version #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: Update apache airflow version #3998

merged 1 commit into from
Jul 14, 2023

Conversation

sthodimi
Copy link
Contributor

@sthodimi sthodimi commented Jul 13, 2023 •
edited by knikure
Loading

Description
Updating the apache airflow version to fix the vulnerability.

Issue #, if available:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sthodimi
Update apache airflow version
81638c0 
**Description**
Updating the apache airflow version
to fix the vulnerability.
@sthodimi sthodimi changed the title Update apache airflow version Fix: Update apache airflow version Jul 13, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 81638c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sthodimi
sthodimi commented Jul 14, 2023
View reviewed changes
Copy link
Contributor Author

@sthodimi sthodimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@knikure knikure changed the title Fix: Update apache airflow version fix: Update apache airflow version Jul 14, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 81638c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 81638c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 81638c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 81638c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #3998 (81638c0) into master (53fe9b7) will decrease coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3998      +/-   ##
==========================================
- Coverage   90.18%   89.46%   -0.73%     
==========================================
  Files        1296      306     -990     
  Lines      114144    28231   -85913     
==========================================
- Hits       102940    25256   -77684     
+ Misses      11204     2975    -8229

see 1602 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 81638c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sthodimi
sthodimi commented Jul 14, 2023
View reviewed changes
Copy link
Contributor Author

@sthodimi sthodimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run sagemaker-python-sdk-notebook-tests, sagemaker-python-sdk-slow-tests

sthodimi
sthodimi commented Jul 14, 2023
View reviewed changes
Copy link
Contributor Author

@sthodimi sthodimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr, notebook-tests, slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 81638c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 81638c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 81638c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@akrishna1995 akrishna1995 self-requested a review July 14, 2023 19:33
sthodimi
sthodimi commented Jul 14, 2023
View reviewed changes
Copy link
Contributor Author

@sthodimi sthodimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 81638c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sthodimi sthodimi marked this pull request as ready for review July 14, 2023 21:17
@sthodimi sthodimi requested a review from a team as a code owner July 14, 2023 21:17
akrishna1995
akrishna1995 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one test failing unrelated to this change

@akrishna1995 akrishna1995 merged commit 1e5e26c into aws:master Jul 14, 2023
knikure
knikure reviewed Jul 14, 2023
View reviewed changes
requirements/extras/test_requirements.txt
@@ -12,7 +12,7 @@ awslogs==0.14.0
black==22.3.0
stopit==1.1.2
# Update tox.ini to have correct version of airflow constraints file
apache-airflow==2.6.0
apache-airflow==2.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment above can you also update the tox.ini file for this apache-airflow version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good let me take a look

knikure added a commit that referenced this pull request Jul 14, 2023
@knikure
Revert "Update apache airflow version (#3998)"
917a50e 
This reverts commit 1e5e26c.
@sthodimi sthodimi mentioned this pull request Jul 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knikure knikure knikure left review comments

@akrishna1995 akrishna1995 akrishna1995 approved these changes

Assignees
No one assigned
Labels
status: ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sthodimi @sagemaker-bot @codecov-commenter @akrishna1995 @knikure