feat: SkipModelValidation in modelRegistry #4124

keshav-chandak · 2023-09-18T04:57:25Z

Issue #, if available:

Description of changes: Added SkipModelValidation for the model Registry step

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-09-18T05:04:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9816b84
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T05:56:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9816b84
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T05:56:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9816b84
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T06:09:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9816b84
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T08:23:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9816b84
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T11:19:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 002405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T11:20:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 002405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T11:29:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 002405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T11:32:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 002405a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T12:11:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 002405a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T16:22:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T16:23:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T16:28:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T16:33:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T17:11:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run pr

sagemaker-bot · 2023-09-18T20:01:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T20:49:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-09-18T20:49:19Z

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.05% ⚠️

Comparison is base (c1af5d7) 90.40% compared to head (7d06c5c) 90.35%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4124      +/-   ##
==========================================
- Coverage   90.40%   90.35%   -0.05%     
==========================================
  Files         990      312     -678     
  Lines       87099    28688   -58411     
==========================================
- Hits        78739    25921   -52818     
+ Misses       8360     2767    -5593

Files Changed	Coverage Δ
src/sagemaker/chainer/model.py	`96.49% <ø> (ø)`
src/sagemaker/estimator.py	`92.95% <ø> (ø)`
src/sagemaker/huggingface/model.py	`88.75% <ø> (ø)`
src/sagemaker/model.py	`93.59% <ø> (ø)`
src/sagemaker/mxnet/model.py	`98.41% <ø> (ø)`
src/sagemaker/pipeline.py	`86.41% <ø> (ø)`
src/sagemaker/pytorch/model.py	`96.82% <ø> (ø)`
src/sagemaker/sklearn/model.py	`92.98% <ø> (ø)`
src/sagemaker/tensorflow/model.py	`96.36% <ø> (ø)`
src/sagemaker/workflow/step_collections.py	`97.95% <ø> (ø)`
... and 3 more

... and 1289 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-09-18T20:53:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-18T21:50:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T00:49:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7d06c5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T05:59:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T06:04:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T06:12:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T06:31:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-09-19T06:54:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7d06c5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

keshav-chandak requested a review from a team as a code owner September 18, 2023 04:57

keshav-chandak requested review from knikure and removed request for a team September 18, 2023 04:57

keshav-chandak force-pushed the feature/skip-model-validation branch from 689e6ce to 9816b84 Compare September 18, 2023 04:58

keshav-chandak force-pushed the feature/skip-model-validation branch from 9816b84 to 002405a Compare September 18, 2023 10:23

Feat: SkipModelValidation in modelRegistry

7d06c5c

keshav-chandak force-pushed the feature/skip-model-validation branch from 002405a to 7d06c5c Compare September 18, 2023 15:24

MadhubalasriB approved these changes Sep 18, 2023

View reviewed changes

saumitravikram approved these changes Sep 18, 2023

View reviewed changes

knikure self-assigned this Sep 18, 2023

knikure changed the title ~~Feat: SkipModelValidation in modelRegistry~~ feat: SkipModelValidation in modelRegistry Sep 18, 2023

knikure reviewed Sep 18, 2023

View reviewed changes

knikure approved these changes Sep 19, 2023

View reviewed changes

knikure merged commit f7cec53 into aws:master Sep 19, 2023

feat: SkipModelValidation in modelRegistry #4124

feat: SkipModelValidation in modelRegistry #4124

Uh oh!

Conversation

keshav-chandak commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 19, 2023

AWS CodeBuild CI Report

Uh oh!

keshav-chandak commented Sep 18, 2023 •

edited

Loading

codecov-commenter commented Sep 18, 2023 •

edited

Loading