Update fw_utils.py - support 2.0.1 container for DDP and Torch distri… #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilinachum
requested review from
mufaddal-rohawala
and removed request for
a team
…buted 2.0.1 exist and it works well with DDP and Torch Distributed, so allowing clients to use this combination.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4127 +/- ##
==========================================
- Coverage 90.40% 90.35% -0.05%
==========================================
Files 990 312 -678
Lines 87099 28688 -58411
==========================================
- Hits 78739 25921 -52818
+ Misses 8360 2767 -5593
☔ View full report in Codecov by Sentry. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
knikure
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fw_utils.py - support 2.0.1 container for DDP and Torch distributed.
Issue #, if available:
Description of changes:
Update fw_utils.py - add support 2.0.1 container for DDP and Torch distruted.
2.0.1 exist and it works well with DDP and Torch Distributed, so allowing clients to use this combination.
see
763104351884.dkr.ecr.us-east-1.amazonaws.com/pytorch-training:2.0.1-gpu-py310-cu118-ubuntu20.04-sagemakerin https://github.com/aws/deep-learning-containers/blob/master/available_images.mdTesting done: Changed fw_utils locally and saw it works fine with DDP and Torch Distributed.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.