doc: specify that input_shape in no longer required for torch 2.0 mod… #4159

HappyAmazonian · 2023-10-03T23:31:42Z

…el compilation

Issue #, if available:

Description of changes: modify comments for Neo input shape derivation feature

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
x] I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…el compilation

jgoyani1

/bot run all

sagemaker-bot · 2023-10-04T18:19:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c07332c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-04T19:07:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c07332c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-04T19:17:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c07332c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-04T19:59:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c07332c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-04T20:34:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c07332c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

zuoyuanh · 2023-10-04T22:48:37Z

Hello, looks like there are some formatting issues with this PR. Would you run the linter to fix the issue?

black-check run-test: commands[0] | black -l 100 --diff --color --check ./
�[1m--- src/sagemaker/model.py	2023-10-04 18:14:51.223285 +0000�[0m
�[1m+++ src/sagemaker/model.py	2023-10-04 18:18:05.813002 +0000�[0m
�[36m@@ -1099,11 +1099,11 @@�[0m
                 ``target_platform_os``, ``target_platform_arch``,
                 and ``target_platform_accelerator``.
             input_shape (dict): Specifies the name and shape of the expected
                 inputs for your trained model in json dictionary form, for
                 example: {'data': [1,3,1024,1024]}, or {'var1': [1,1,28,28],
�[31m-                'var2': [1,1,28,28]}. Input shape is optional for those models traced with torch 2.0, �[0m
�[32m+                'var2': [1,1,28,28]}. Input shape is optional for those models traced with torch 2.0,�[0m
                 see pytorch section of this document for detail:
                 https://docs.aws.amazon.com/sagemaker/latest/dg/neo-compilation-preparing-model.html
             output_path (str): Specifies where to store the compiled model
             role (str): Execution role
             tags (list[dict]): List of tags for labeling a compilation job. For
would reformat src/sagemaker/model.py

Oh no! ðŸ’¥ ðŸ’” ðŸ’¥
1 file would be reformatted, 927 files would be left unchanged.
ERROR: InvocationError for command /codebuild/output/src2275916367/src/github.com/aws/sagemaker-python-sdk/.tox/black-check/bin/black -l 100 --diff --color --check ./ (exited with code 1)

HappyAmazonian · 2023-10-05T22:05:10Z

hi could u try to rerun the tests?

jgoyani1

/bot run all

sagemaker-bot · 2023-10-09T21:39:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0355b35
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T21:51:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0355b35
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T21:53:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0355b35
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T22:23:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0355b35
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T22:35:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0355b35
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run all

sagemaker-bot · 2023-10-12T20:09:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a77a028
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-12T20:22:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a77a028
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-12T20:23:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a77a028
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-12T20:28:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a77a028
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-12T21:06:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a77a028
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

HappyAmazonian · 2023-10-13T23:10:33Z

Could someone follow up on this? It is like run-tests-->waiting review --> merge in new change --> run-tests-->....

aws#4159) Co-authored-by: Akash Goel <[email protected]>

doc: specify that input_shape in no longer required for torch 2.0 mod…

1d2b11c

…el compilation

HappyAmazonian requested a review from a team as a code owner October 3, 2023 23:31

HappyAmazonian requested review from jgoyani1 and removed request for a team October 3, 2023 23:31

huiqunli approved these changes Oct 3, 2023

View reviewed changes

jgoyani1 reviewed Oct 4, 2023

View reviewed changes

Merge branch 'master' into neo-input-shape-derivation-comment

310354e

HappyAmazonian force-pushed the neo-input-shape-derivation-comment branch from c07332c to 310354e Compare October 5, 2023 20:30

Merge branch 'master' into neo-input-shape-derivation-comment

92e085f

HappyAmazonian added 3 commits October 5, 2023 15:58

Merge branch 'master' into neo-input-shape-derivation-comment

48aebce

Merge branch 'master' into neo-input-shape-derivation-comment

b21628b

Merge branch 'master' into neo-input-shape-derivation-comment

0355b35

jgoyani1 reviewed Oct 9, 2023

View reviewed changes

goelakash and others added 2 commits October 9, 2023 16:51

Merge branch 'master' into neo-input-shape-derivation-comment

c958e9a

Merge branch 'master' into neo-input-shape-derivation-comment

714caec

knikure assigned jgoyani1 Oct 11, 2023

HappyAmazonian added 2 commits October 11, 2023 14:05

Merge branch 'master' into neo-input-shape-derivation-comment

f5a392e

Merge branch 'master' into neo-input-shape-derivation-comment

a77a028

knikure reviewed Oct 12, 2023

View reviewed changes

Merge branch 'master' into neo-input-shape-derivation-comment

b35aff4

HappyAmazonian added 2 commits October 16, 2023 11:08

Merge branch 'master' into neo-input-shape-derivation-comment

5ec809b

Merge branch 'master' into neo-input-shape-derivation-comment

2242958

knikure approved these changes Oct 17, 2023

View reviewed changes

knikure merged commit 1f9def5 into aws:master Oct 17, 2023

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Oct 23, 2023

doc: specify that input_shape in no longer required for torch 2.0 mod… (

b37702c

aws#4159) Co-authored-by: Akash Goel <[email protected]>

doc: specify that input_shape in no longer required for torch 2.0 mod… #4159

doc: specify that input_shape in no longer required for torch 2.0 mod… #4159

Uh oh!

Conversation

HappyAmazonian commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

jgoyani1 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 4, 2023

AWS CodeBuild CI Report

Uh oh!

zuoyuanh commented Oct 4, 2023

Uh oh!

HappyAmazonian commented Oct 5, 2023

Uh oh!

jgoyani1 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2023

AWS CodeBuild CI Report

Uh oh!

HappyAmazonian commented Oct 13, 2023

Uh oh!

Uh oh!

HappyAmazonian commented Oct 3, 2023 •

edited

Loading