-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: add image_uris_unit_test pytest mark #4211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: add image_uris_unit_test pytest mark #4211
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
8291114
to
10beef6
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4211 +/- ##
==========================================
+ Coverage 90.27% 90.32% +0.05%
==========================================
Files 993 320 -673
Lines 87861 29559 -58302
==========================================
- Hits 79313 26700 -52613
+ Misses 8548 2859 -5689
☔ View full report in Codecov by Sentry. |
Issue #, if available:
Description of changes:
pytest_collection_modifyitems
hook to mark all tests intests/unit/sagemaker/image_uris
with pytest.mark.image_uris_unit_testpytest_collection_modifyitems
is called after all test items collectedimage_uris_unit_test
pytest markTesting done:
tox -e py310 -- -s -vv -m "image_uris_unit_test" tests/unit
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.