-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: Allow either instance_type or instance_group to be defined in… #4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Allow either instance_type or instance_group to be defined in… #4232
Conversation
4bb1676
to
e0c8dff
Compare
… distributed training config.
e0c8dff
to
b9196c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d01d6ea
to
f034641
Compare
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4232 +/- ##
==========================================
+ Coverage 90.27% 90.31% +0.04%
==========================================
Files 993 320 -673
Lines 87861 29750 -58111
==========================================
- Hits 79313 26869 -52444
+ Misses 8548 2881 -5667
☔ View full report in Codecov by Sentry. |
… distributed training config.
Issue #, if available:
Description of changes:
Allowing distribution configurations for a distributed training job to define either instance_type or instance_group.
Testing done:
Ran all unit, integration tests and pre-commit checks.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.