support nvidia-docker2 natively in local mode. #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local Mode wit GPU relied on the environment having the nvidia runtime as default. This changes that so that runtime: nvidia is passed in docker-compose.yaml allowing local mode to work with a vanilla nvidia-docker2 installation.
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 93.56% 93.71% +0.15%
==========================================
Files 55 55
Lines 4008 4010 +2
==========================================
+ Hits 3750 3758 +8
+ Misses 258 252 -6
Continue to review full report at Codecov.
|
iquintero
force-pushed
the
nvidia_runtime
branch
from
69b5631 to
13a7027
Compare
|
+1 I was looking at the same thing. |
docker-compose was not a dependency of the SDk but it is required for local mode.
iquintero
force-pushed
the
nvidia_runtime
branch
from
13a7027 to
a8603f6
Compare
laurenyu
approved these changes
Oct 12, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
Local Mode wit GPU relied on the environment having the nvidia runtime as default. This changes that so that runtime: nvidia is passed in docker-compose.yaml allowing local mode to work with a vanilla nvidia-docker2 installation.
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
add pytorch HPO sample notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local Mode with GPU relied on the environment having
the nvidia runtime as default. This changes that so that
runtime: nvidia is passed in docker-compose.yaml allowing
local mode to work with a vanilla nvidia-docker2 installation.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.