Skip to content

fix: Fix Experiment Run integ test w.r.t unexpected boto3 version #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: Fix Experiment Run integ test w.r.t unexpected boto3 version #4286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/data/experiment/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@
# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
# express or implied. See the License for the specific language governing
# permissions and limitations under the License.
import json
import logging
import os
import pickle as pkl

import boto3
import numpy as np
import sagemaker_xgboost_container.encoder as xgb_encoders

sdk_name = "sagemaker-dev-1.0.tar.gz"
code_dir = "/opt/ml/code"

sdk_file = f"{code_dir}/{sdk_name}"
os.system(f"pip install {sdk_file}")

import json
import logging
import pickle as pkl
import boto3
import numpy as np
import sagemaker_xgboost_container.encoder as xgb_encoders


def _get_client_config_in_dict(cfg_in_str) -> dict:
return json.loads(cfg_in_str) if cfg_in_str else None
Expand Down
7 changes: 3 additions & 4 deletions tests/data/experiment/process_job_script_for_run_clz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,14 @@
"""This script file runs on SageMaker processing job"""
from __future__ import absolute_import

import json
import logging
import os
import boto3

sdk_file = "sagemaker-dev-1.0.tar.gz"
os.system(f"pip install {sdk_file}")


import json
import logging
import boto3
from sagemaker import Session
from sagemaker.experiments import load_run

Expand Down
8 changes: 4 additions & 4 deletions tests/data/experiment/train_job_script_for_run_clz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
"""This script file runs on SageMaker training job"""
from __future__ import absolute_import

import json
import logging
import time
import os
import boto3

sdk_file = "sagemaker-dev-1.0.tar.gz"
os.system(f"pip install {sdk_file}")

import json
import logging
import time
import boto3
from sagemaker import Session
from sagemaker.experiments import load_run, Run

Expand Down
5 changes: 0 additions & 5 deletions tests/integ/sagemaker/experiments/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ def verify_is_run():
_RUN_LOAD = "load"


@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
def test_run_from_local_and_train_job_and_all_exp_cfg_match(
sagemaker_session,
dev_sdk_tar,
Expand Down Expand Up @@ -272,7 +271,6 @@ def test_run_from_local_and_train_job_and_all_exp_cfg_match(
)


@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
def test_run_from_local_and_train_job_and_exp_cfg_not_match(
sagemaker_session,
dev_sdk_tar,
Expand Down Expand Up @@ -359,7 +357,6 @@ def test_run_from_local_and_train_job_and_exp_cfg_not_match(
)


@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
def test_run_from_train_job_only(
sagemaker_session,
dev_sdk_tar,
Expand Down Expand Up @@ -409,7 +406,6 @@ def test_run_from_train_job_only(


# dev_sdk_tar is required to trigger generating the dev SDK tar
@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
def test_run_from_processing_job_and_override_default_exp_config(
sagemaker_session,
dev_sdk_tar,
Expand Down Expand Up @@ -571,7 +567,6 @@ def test_run_from_transform_job(


# dev_sdk_tar is required to trigger generating the dev SDK tar
@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
def test_load_run_auto_pass_in_exp_config_to_job(
sagemaker_session,
dev_sdk_tar,
Expand Down