Skip to content

feature: Add TF 2.14 Graviton Inference support #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Apr 1, 2024

Issue #, if available:

Description of changes:
Add image_uri_config options for TensorFlow 2.14 inference with Graviton instance types

Testing done:
Local unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@saimidu saimidu requested a review from a team as a code owner April 1, 2024 19:29
@saimidu saimidu requested review from mufaddal-rohawala and removed request for a team April 1, 2024 19:29
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (6a38060) to head (9006e1c).
Report is 9 commits behind head on master.

❗ Current head 9006e1c differs from pull request most recent head 06b372e. Consider uploading reports for the commit 06b372e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   87.50%   87.44%   -0.06%     
==========================================
  Files         391      389       -2     
  Lines       37098    36888     -210     
==========================================
- Hits        32461    32256     -205     
+ Misses       4637     4632       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9006e1c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure force-pushed the add_tf214_graviton branch from 4982809 to 06b372e Compare April 16, 2024 15:28
@knikure knikure temporarily deployed to manual-approval April 16, 2024 15:28 — with GitHub Actions Inactive
@knikure knikure temporarily deployed to manual-approval April 16, 2024 16:32 — with GitHub Actions Inactive
@knikure knikure merged commit 686160b into aws:master Apr 16, 2024
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants