Skip to content

feature: Add and use sagemaker_schema_inference_artifacts dependency for huggingface in schema builder (question-answering only) #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ShailavTaneja
Copy link
Contributor

@ShailavTaneja ShailavTaneja commented Apr 1, 2024

Description of changes:

feature: Add and use sagemaker_schema_inference_artifacts dependency for huggingface in schema builder (question-answering only)

Testing done:

E2E Question Answering Endpoint Mode Task validation (integ test)
Task and Model: ("bert-large-uncased-whole-word-masking-finetuned-squad", "question-answering", "ml.m5.xlarge")

tox -e py310 -- -v -s tests/integ/sagemaker/serve/test_schema_builder.py::test_model_builder_happy_path_with_task_provided_remote_schema_mode

Unit Tests

tox -e py310 -- -v -s tests/unit/sagemaker/serve/builder/test_model_builder.py

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…for huggingface in schema builder (question-answering only)
@ShailavTaneja ShailavTaneja requested a review from a team as a code owner April 1, 2024 19:48
@ShailavTaneja ShailavTaneja requested review from zhaoqizqwang and removed request for a team April 1, 2024 19:48
@ShailavTaneja
Copy link
Contributor Author

NOTE: BLOCKED UNTIL - https://github.com/aws/sagemaker-schema-inference-artifacts/pull/18 IS MERGED and v0.0.2 is released.
cc @samruds

@samruds
Copy link
Collaborator

samruds commented Apr 1, 2024

@@ -64,6 +64,7 @@
)
from sagemaker.workflow.entities import PipelineVariable
from sagemaker.huggingface.llm_utils import get_huggingface_model_metadata
from sagemaker_schema_inference_artifacts.huggingface import remote_schema_retriever
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving this import to be in the try catch block where we use remote_schema_retriever and catching an import error there if module is not installed.

The reason for the suggestion is: this dependencies are extra dependencies and not all the customers want to opt in to use this feature. example: #4549

@samruds samruds requested review from makungaj1 and removed request for zhaoqizqwang April 1, 2024 23:20
@ShailavTaneja ShailavTaneja deleted the hf_changes_qa_only branch April 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants