Skip to content

fix: remove trailing slash when uploading to S3 with dataset_builder.to_csv_file #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mkkatica
Copy link
Contributor

@mkkatica mkkatica commented Apr 9, 2024

Issue #, if available: #4569

Description of changes: Use rstrip to remove trailing slash when uploading the temp file to s3 during dataset creation.

Testing done: Installed the modified version and ran the code that was previously failing

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mkkatica mkkatica force-pushed the fix/trailing-slash-featurestore branch from f635551 to be57478 Compare April 10, 2024 16:50
@mkkatica mkkatica marked this pull request as ready for review April 10, 2024 16:54
@mkkatica mkkatica requested a review from a team as a code owner April 10, 2024 16:54
@mkkatica mkkatica requested review from Aditi2424 and removed request for a team April 10, 2024 16:54
@mkkatica
Copy link
Contributor Author

Are there any existing tests for DatasetBuilder.to_csv_file()? I couldn't find any in tests/integ/sagemaker/feature_store.

@mkkatica mkkatica force-pushed the fix/trailing-slash-featurestore branch from 868e4df to 190fe22 Compare April 10, 2024 16:57
@mkkatica mkkatica temporarily deployed to manual-approval April 10, 2024 16:58 — with GitHub Actions Inactive
@knikure knikure self-assigned this Apr 16, 2024
@knikure knikure force-pushed the fix/trailing-slash-featurestore branch from edc085a to 1e9760f Compare April 16, 2024 19:06
@knikure knikure temporarily deployed to manual-approval April 16, 2024 19:08 — with GitHub Actions Inactive
@knikure knikure merged commit 48faa9d into aws:master Apr 16, 2024
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing Slash in create_dataset output_path causes issues with joining results
2 participants