Support optional input channels in local mode. #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquintero
suggested changes
Nov 8, 2018
| def create_training_job(self, TrainingJobName, AlgorithmSpecification, InputDataConfig, OutputDataConfig, | ||
| ResourceConfig, **kwargs): | ||
| def create_training_job(self, TrainingJobName, AlgorithmSpecification, OutputDataConfig, | ||
| ResourceConfig, InputDataConfig=None, **kwargs): |
There was a problem hiding this comment.
if the first line of this method becomes
InputDataConfig = InputDataConfig or {}
Then you don't need to actually touch any other part of the code as all the for loops will just not happen.
src/sagemaker/local/image.py
Outdated
| if 'ContentType' in c: | ||
| json_input_data_config[channel_name]['ContentType'] = c['ContentType'] | ||
| if input_data_config: | ||
| print(input_data_config) |
There was a problem hiding this comment.
can you remove this print while we are at it?
nadiaya
force-pushed
the
local-mode-input
branch
from
3481e2b to
5611512
Compare
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=====================================
Coverage 94% 94%
=====================================
Files 57 57
Lines 4284 4284
=====================================
Hits 4027 4027
Misses 257 257
Continue to review full report at Codecov.
|
iquintero
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support optional input channels in local mode.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.