Skip to content

Adding Object2Vec support to SageMaker Python SDK #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

pnpnpn
Copy link
Contributor

@pnpnpn pnpnpn commented Nov 8, 2018

Issue #, if available:

Description of changes:
Adding Object2Vec support to SageMaker Python SDK

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #467 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #467      +/-   ##
========================================
+ Coverage   93.73%    94%   +0.26%     
========================================
  Files          56     57       +1     
  Lines        4199   4284      +85     
========================================
+ Hits         3936   4027      +91     
+ Misses        263    257       -6
Impacted Files Coverage Δ
src/sagemaker/tuner.py 96.8% <ø> (ø) ⬆️
src/sagemaker/amazon/amazon_estimator.py 88.8% <ø> (ø) ⬆️
src/sagemaker/amazon/object2vec.py 100% <100%> (ø)
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/local/image.py 90% <0%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5201c60...8973293. Read the comment docs.

laurenyu
laurenyu previously approved these changes Nov 8, 2018
@@ -23,6 +23,7 @@
from sagemaker.amazon.randomcutforest import (RandomCutForest, RandomCutForestModel, # noqa: F401
RandomCutForestPredictor)
from sagemaker.amazon.knn import KNN, KNNModel, KNNPredictor # noqa: F401
from sagemaker.amazon.object2vec import Object2Vec, Object2VecModel # noqa: F401

from sagemaker.analytics import TrainingJobAnalytics, HyperparameterTuningJobAnalytics # noqa: F401
from sagemaker.local.local_session import LocalSession # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the version on line 39 of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@laurenyu laurenyu merged commit 9285b6a into aws:master Nov 8, 2018
@pnpnpn pnpnpn deleted the object2vec-rev4 branch April 30, 2019 14:43
metrizable added a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants