feat: FastAPI integration for In_Process Mode (2/2) #4808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makungaj1
reviewed
Aug 15, 2024
|
|
||
| count = 1 | ||
| time_limit = datetime.now() + timedelta(seconds=20) |
There was a problem hiding this comment.
nit: time_limit = datetime.now() + timedelta(seconds=5)
There was a problem hiding this comment.
Will fix, thank you
makungaj1
reviewed
Aug 15, 2024
| config = uvicorn.Config( | ||
| _app, | ||
| host="127.0.0.1", | ||
| port=9007, |
There was a problem hiding this comment.
q: can we let port be dynamic?
There was a problem hiding this comment.
We are researching this, will be an action item.
added 2 commits
August 15, 2024 17:08
samruds
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Approve please address minor changes and get additional approval from @makungaj1
bryannahm1
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
makungaj1
approved these changes
Aug 16, 2024
added 3 commits
August 20, 2024 13:35
bryannahm1
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
bryannahm1
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
makungaj1
approved these changes
Aug 21, 2024
bryannahm1
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
samruds
approved these changes
Aug 22, 2024
makungaj1
approved these changes
Aug 22, 2024
added 2 commits
August 22, 2024 13:53
…emaker-python-sdk into fastapi-inprocess ssss
bryannahm1
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
benieric
reviewed
Aug 22, 2024
| @@ -1,2 +1,5 @@ | |||
| accelerate>=0.24.1,<=0.27.0 | |||
| sagemaker_schema_inference_artifacts>=0.0.5 | |||
| uvicorn>=0.30.1 | |||
There was a problem hiding this comment.
Are these needed? Doesn't look like we import them anywhere?
There was a problem hiding this comment.
They're imported in the app.py file
benieric
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Introduced new app.py and local_run.sh files that allow for the server to run requests using FastAPI and uvicorn.
Testing done:
Integr tests run locally.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.