Skip to content

fix test for pytest 4 #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix test for pytest 4 #482

merged 1 commit into from
Nov 14, 2018

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

fix test failing due to fixture error

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #482 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   94.02%   93.88%   -0.15%     
==========================================
  Files          57       57              
  Lines        4269     4269              
==========================================
- Hits         4014     4008       -6     
- Misses        255      261       +6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.08% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a8598...a6346d9. Read the comment docs.

@laurenyu laurenyu merged commit 46b10fa into aws:master Nov 14, 2018
@jesterhazy jesterhazy deleted the je-pytest4 branch November 14, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants