Skip to content

support latest container version in image_uris and DJLModel for lmi c… #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Aug 15, 2024

…ontainers

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siddvenk siddvenk requested a review from a team as a code owner August 15, 2024 18:39
@siddvenk siddvenk requested a review from mohanasudhan August 15, 2024 18:39
@@ -43,7 +43,7 @@ def __init__(
self,
model_id: Optional[str] = None,
engine: Optional[str] = None,
djl_version: str = "0.28.0",
djl_version: str = "latest",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@siddvenk
Copy link
Contributor Author

@mohanasudhan I think the integration test failure is not related to the changes here - I see them failing for all open PRs currently. If that's the case, can this be merged?

@benieric benieric merged commit 9101d23 into aws:master Sep 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants