Skip to content

chore: add flaky test markers & skip region with low P3 instance capacity #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

benieric
Copy link
Collaborator

@benieric benieric commented Sep 12, 2024

Issue #, if available:

Description of changes:

  • Adding flaky test marker to reduce CI pain and unblock release
  • Skip some integs where P3 instance have low capacity
  • Add 1 min retry for flaky unit tests

Regional tests failing with capacity issue like:

 sagemaker.exceptions.CapacityError: Error for Processing job test-huggingface-2024-09-11-22-13-48-503: Failed. Reason: CapacityError: Unable to provision requested ML compute capacity. Please retry using a different ML instance type.. Check troubleshooting guide for common errors: https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-python-sdk-troubleshooting.html

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner September 12, 2024 15:36
@benieric benieric requested a review from nileshvd September 12, 2024 15:36
@benieric benieric changed the title chore: add flaky test markers chore: add flaky test markers & skip region with low p3 instance Sep 12, 2024
@benieric benieric changed the title chore: add flaky test markers & skip region with low p3 instance chore: add flaky test markers & skip region with low p3 instance capacity Sep 12, 2024
@benieric benieric changed the title chore: add flaky test markers & skip region with low p3 instance capacity chore: add flaky test markers & skip region with low P3 instance capacity Sep 12, 2024
@benieric benieric merged commit 8be1f38 into aws:master Sep 12, 2024
14 checks passed
@benieric benieric deleted the add-flaky-marker branch September 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants