Skip to content

Add a check for S3 paths being incorrectly passed as an entry point #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2018

Conversation

laurenyu
Copy link
Contributor

to address the concern in #471

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #500 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   94.29%   94.16%   -0.13%     
==========================================
  Files          59       59              
  Lines        4610     4612       +2     
==========================================
- Hits         4347     4343       -4     
- Misses        263      269       +6
Impacted Files Coverage Δ
src/sagemaker/estimator.py 90.57% <100%> (+0.06%) ⬆️
src/sagemaker/local/image.py 88.08% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b096cd1...e285da0. Read the comment docs.

@jesterhazy jesterhazy merged commit 5b3ab50 into aws:master Dec 9, 2018
@laurenyu laurenyu deleted the better-error-message branch December 9, 2018 17:22
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants