Skip to content

py_version doc fixes #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 23, 2025
Merged

py_version doc fixes #5048

merged 7 commits into from
Feb 23, 2025

Conversation

sage-maker
Copy link
Collaborator

Issue #, if available: #3318

Description of changes: Documentation changes for py_version

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sage-maker sage-maker requested a review from a team as a code owner February 19, 2025 17:05
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (8a559ad) to head (0299688).
Report is 119 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5048      +/-   ##
==========================================
- Coverage   86.56%   86.56%   -0.01%     
==========================================
  Files         440      440              
  Lines       42835    42834       -1     
==========================================
- Hits        37080    37079       -1     
  Misses       5755     5755              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sage-maker sage-maker changed the title Parknate doc fixes WIP py_version doc fixes WIP Feb 20, 2025
@sage-maker sage-maker changed the title py_version doc fixes WIP py_version doc fixes Feb 23, 2025
@sage-maker sage-maker merged commit d37292f into master Feb 23, 2025
13 of 14 checks passed
@sage-maker sage-maker deleted the parknate-doc-fixes branch February 23, 2025 16:16
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants