Skip to content

update sdk for new re:invent 2018 features #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 29, 2018
Merged

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

update sdk for new re:invent 2018 features

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested a review from yuanzhua November 29, 2018 02:18
@codecov-io
Copy link

Codecov Report

Merging #513 into master will decrease coverage by 1.55%.
The diff coverage is 84.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #513      +/-   ##
=========================================
- Coverage   94.26%   92.7%   -1.56%     
=========================================
  Files          59      71      +12     
  Lines        4623    5336     +713     
=========================================
+ Hits         4358    4947     +589     
- Misses        265     389     +124
Impacted Files Coverage Δ
src/sagemaker/amazon/amazon_estimator.py 87.68% <0%> (-1.29%) ⬇️
src/sagemaker/fw_utils.py 100% <100%> (ø) ⬆️
src/sagemaker/chainer/model.py 96.42% <100%> (ø) ⬆️
src/sagemaker/tensorflow/serving.py 98.33% <100%> (ø) ⬆️
src/sagemaker/sparkml/__init__.py 100% <100%> (ø)
src/sagemaker/local/entities.py 95.29% <100%> (+0.06%) ⬆️
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/sklearn/defaults.py 100% <100%> (ø)
src/sagemaker/fw_registry.py 100% <100%> (ø)
src/sagemaker/sklearn/__init__.py 100% <100%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c055b...7fad99e. Read the comment docs.

@jesterhazy jesterhazy merged commit db1876d into aws:master Nov 29, 2018
@laurenyu laurenyu mentioned this pull request Feb 25, 2020
7 tasks
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants