Skip to content

Update version to 1.16.1.post1 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 30, 2018
Merged

Update version to 1.16.1.post1 #516

merged 7 commits into from
Nov 30, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Nov 29, 2018

Update version to 1.16.1.post1

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested a review from icywang86rui November 29, 2018 19:11
icywang86rui
icywang86rui previously approved these changes Nov 29, 2018
Copy link
Contributor

@jesterhazy jesterhazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc-fixes not enhancements

@nadiaya nadiaya dismissed jesterhazy’s stale review November 29, 2018 19:24

It doesn't fix anything, so it's not doc-fix.

@codecov-io
Copy link

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #516   +/-   ##
======================================
  Coverage    92.7%   92.7%           
======================================
  Files          71      71           
  Lines        5336    5336           
======================================
  Hits         4947    4947           
  Misses        389     389
Impacted Files Coverage Δ
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650cfa8...9cd7918. Read the comment docs.

CHANGELOG.rst Outdated

* feature: Documentation: update TensorFlow README for Script Mode
* enhancement: Documentation: add documentation for Reinforcement Learning Estimator.
* enhancement: Documentation: update TensorFlow README for Script Mode
Copy link
Contributor

@laurenyu laurenyu Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the past, when the documentation update is for adding explanations for a new feature, we've labeled it as a "feature" (e.g. 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.7.0, 1.13.0) or a "doc-fix" (e.g. 1.10.1, 1.11.1, 1.14.2). This isn't really an "enhancement"; if the documentation were just further clarifying something that was already written, it'd seem more like an "enhancement".

@nadiaya nadiaya changed the title Update version to 1.16.1.1 Update version to 1.16.1.post1 Nov 29, 2018
jesterhazy
jesterhazy previously approved these changes Nov 29, 2018
@nadiaya nadiaya merged commit 92f6ed2 into aws:master Nov 30, 2018
@nadiaya nadiaya deleted the 1.6.2 branch November 30, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants