-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: Improve defaults handling in ModelTrainer #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pintaoz-aws
merged 20 commits into
aws:master
from
benieric:master-update-default-configs
May 15, 2025
Merged
change: Improve defaults handling in ModelTrainer #5170
pintaoz-aws
merged 20 commits into
aws:master
from
benieric:master-update-default-configs
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a89f6a
to
6c750be
Compare
4d8b871
to
4a189d1
Compare
4a189d1
to
152a50c
Compare
pintaoz-aws
previously approved these changes
May 13, 2025
df700bc
to
f5791ce
Compare
5a3041f
to
a9a68ba
Compare
pintaoz-aws
approved these changes
May 15, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5047 #5116
Description of changes:
Add missing dependency for
ModelTrainer
causing import errorsImprove defaults handling in
ModelTrainer
Align all training artifacts to be uploaded to the default s3 path for a training job -
s3://<default_bucket>/<default_prefix>/<base_job_name>/<job_name>/
Default handling of
InputDataConfig
- any inputs uploaded byModelTrainer
will be uploaded under the input directory in artifacts bucket for training job like below.OutputDataConfig
- when provided a path likeoutput_data_config.s3_output_path = f"s3://{default_bucket}/{default_bucket_prefix}/{base_job_name}
, Output artifacts will appear in the artifacts bucket for the training job like. Platform will automatically<training_job_name>/output
to thes3_output_path
:TensorBoardOutputConfig
- when provided a path liketensor_board_output_config.s3_output_path = f"s3://{default_bucket}/{default_bucket_prefix}/{base_job_name}
, TensorBoard output artifacts will appear in the artifacts bucket for the training job like below. Platform will automatically add<training_job_name>/tensorboard-output
to thes3_output_path
:CheckpointConfig
- when provided a path likecheckpoint_config.s3_uri = f"s3://{default_bucket}/{default_bucket_prefix}/{base_job_name}/{base_job_name-<timestamp>}/checkpoints
, checkpoints will be uploaded to the artifacts bucket like below. Notice that Platform respects thes3_uri
and does not append extra paths in output.Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.