Skip to content

change version range for requests dependency #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Dec 7, 2018

…nd docker

Issue #, if available:
If requests==1.12.4 is installed, import sagemaker will get version conflicting error since docker-compose and docker-py requires different version range of requests. To avoid this, we'd better set the version constraint here (at least temporarily)
docker-compose requires https://github.com/docker/compose/blob/master/setup.py#L36
docker-py requires https://github.com/docker/docker-py/blob/master/setup.py

Description of changes:
Require requests module to have version in the intersection of what docker compose and docker-py require.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested review from laurenyu and iquintero December 7, 2018 01:28
@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          71       71           
  Lines        5348     5348           
=======================================
  Hits         4961     4961           
  Misses        387      387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf38de...ef75afb. Read the comment docs.

laurenyu
laurenyu previously approved these changes Dec 7, 2018
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@jesterhazy jesterhazy changed the title Define version range of requests module to work with docker-compose a… change version range for requests dependency Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants