Remove retry_id in Airflow job name, needs more design on this #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
- Coverage 92.78% 92.78% -0.01%
==========================================
Files 71 71
Lines 5367 5366 -1
==========================================
- Hits 4980 4979 -1
Misses 387 387
Continue to review full report at Codecov.
|
nadiaya
suggested changes
Dec 20, 2018
CHANGELOG.rst
Outdated
| @@ -5,8 +5,7 @@ CHANGELOG | |||
| 1.16.3 | |||
| ====== | |||
|
|
|||
| * bug-fix: Local Mode: Allow support for SSH in local mode | |||
There was a problem hiding this comment.
Can't really remove it - it's already released. Please add a new record for the revert change in the next version.
nadiaya
previously approved these changes
Dec 20, 2018
laurenyu
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Just appending retry id after a job name is not a good solution for solving naming collisions in Airflow operators. It may add more risk for users to manage jobs across operators. So revert the changes in:
2ad6c1d
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.