Skip to content

Supporting inter-container traffic encryption flag #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Supporting inter-container traffic encryption flag #595

merged 2 commits into from
Jan 11, 2019

Conversation

jigsaw004
Copy link
Contributor

Description of changes:
We're supporting the encrypt_inter_container_traffic flag while instantiating Estimator objects. Setting this flag as True in the VPC Mode will create training jobs with inter-container traffic encrypted between them.

Testing

  • Unit Tests
    tox tests/unit
  • Integ Tests
    python setup.py sdist && cd dist
    pip install --upgrade sagemaker-1.17.0.tar.gz && cd ..
    pytest tests/integ

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ChoiByungWook ChoiByungWook self-requested a review January 10, 2019 23:07
ChoiByungWook
ChoiByungWook previously approved these changes Jan 10, 2019
Copy link
Contributor

@ChoiByungWook ChoiByungWook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jigsaw004 jigsaw004 changed the title Supporting inter-container traffic encryption flag (#138) Supporting inter-container traffic encryption flag Jan 10, 2019
@ChoiByungWook ChoiByungWook merged commit 0cd7aa1 into aws:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants