Skip to content

Fix SKLearnModel default account in image uri. #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2019

Conversation

ericangelokim
Copy link
Contributor

Issue #, if available:

Description of changes:

The SKLearnModel was defaulting to the wrong account because it was still using the fw_utils.py file methods. MLeaps and SKLearn use its own framework registry (since they use different accounts).

Also fixed exception messages.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -12,4 +12,6 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

SKLEARN_NAME = "scikit-learn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use single quotes

same below

@laurenyu laurenyu merged commit 6879d31 into aws:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants