Fix SKLearnModel default account in image uri. #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
reviewed
Feb 5, 2019
src/sagemaker/sklearn/defaults.py
Outdated
| @@ -12,4 +12,6 @@ | |||
| # language governing permissions and limitations under the License. | |||
| from __future__ import absolute_import | |||
|
|
|||
| SKLEARN_NAME = "scikit-learn" | |||
There was a problem hiding this comment.
nit: use single quotes
same below
laurenyu
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The SKLearnModel was defaulting to the wrong account because it was still using the fw_utils.py file methods. MLeaps and SKLearn use its own framework registry (since they use different accounts).
Also fixed exception messages.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.