Skip to content

revert change: moving not canary TFS tests to local mode #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jesterhazy
Copy link
Contributor

Reverts #870

This change broke overnight complete test suite.

@jesterhazy jesterhazy requested a review from mvsusp June 22, 2019 14:57
@jesterhazy
Copy link
Contributor Author

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu
Copy link
Contributor

local mode tests need to be annotated to not break the overnight canary run. example: https://github.com/aws/sagemaker-python-sdk/blob/master/tests/integ/test_local_mode.py#L86

@jesterhazy
Copy link
Contributor Author

closing due to formatting changes in master. will reopen using @laurenyu's mark suggestion.

@jesterhazy jesterhazy closed this Jun 24, 2019
@laurenyu laurenyu deleted the revert-870-mvs-tfs-tests branch July 23, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants