Skip to content

fix: prevent multiple values error in sklearn.transformer() #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2019
Merged

fix: prevent multiple values error in sklearn.transformer() #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f712776
fix: prevent multiple values error in sklearn.transformer()
jesterhazy Aug 12, 2019
ecbc208
format fix
jesterhazy Aug 12, 2019
c3ccb9e
fix format
jesterhazy Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sagemaker/sklearn/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ def create_model(
object. See :func:`~sagemaker.sklearn.model.SKLearnModel` for full details.
"""
role = role or self.role

# remove unwanted entry_point kwarg
if "entry_point" in kwargs:
logger.debug("removing unused entry_point argument: %s", str(kwargs["entry_point"]))
kwargs = {k: v for k, v in kwargs.items() if k != "entry_point"}

return SKLearnModel(
self.model_data,
role,
Expand Down
20 changes: 20 additions & 0 deletions tests/unit/test_sklearn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,26 @@ def test_sklearn(strftime, sagemaker_session, sklearn_version):
assert isinstance(predictor, SKLearnPredictor)


def test_transform_multiple_values_for_entry_point_issue(sagemaker_session, sklearn_version):
# https://github.com/aws/sagemaker-python-sdk/issues/974
sklearn = SKLearn(
entry_point=SCRIPT_PATH,
role=ROLE,
sagemaker_session=sagemaker_session,
train_instance_type=INSTANCE_TYPE,
py_version=PYTHON_VERSION,
framework_version=sklearn_version,
)

inputs = "s3://mybucket/train"

sklearn.fit(inputs=inputs)

transformer = sklearn.transformer(instance_count=1, instance_type="ml.m4.xlarge")
# if we got here, we didn't get a "multiple values" error
assert transformer is not None


def test_fail_distributed_training(sagemaker_session, sklearn_version):
with pytest.raises(AttributeError) as error:
SKLearn(
Expand Down