Update method comments and modify model_dir.

Author: Chuyang Deng

src/sagemaker_tensorflow_container/training.py

@@ -193,8 +193,10 @@ def main():
     hyperparameters = framework.env.read_hyperparameters()
     env = framework.training_env(hyperparameters=hyperparameters)
 
+    # If the training job is part of the multiple training jobs for tuning, we need to append the training job name to
+    # model_dir in case they read from/write to the same object
     if '_tuning_objective_metric' in hyperparameters:
-        env.hyperparameters['model_dir'] = env.job_name
+        env.hyperparameters['model_dir'] = '{}-{}'.format(hyperparameters.get('model_dir'), env.job_name)
 
     s3_utils.configure(env.hyperparameters.get('model_dir'), os.environ.get('SAGEMAKER_REGION'))
     logger.setLevel(env.log_level)

test/unit/test_training.py

@@ -254,6 +254,7 @@ def test_main(configure_s3_env, read_hyperparameters, training_env,
     train.assert_called_once_with(single_machine_training_env)
     configure_s3_env.assert_called_once()
 
+
 @patch('sagemaker_tensorflow_container.training.logger')
 @patch('sagemaker_tensorflow_container.training.train')
 @patch('logging.Logger.setLevel')
@@ -280,4 +281,5 @@ def test_main_tunning_model_dir(configure_s3_env, read_hyperparameters, training
     training_env.return_value = single_machine_training_env
     os.environ['SAGEMAKER_REGION'] = REGION
     training.main()
-    configure_s3_env.assert_called_once_with(single_machine_training_env.job_name, REGION)
+    expected_model_dir = '{}-{}'.format(MODEL_DIR, single_machine_training_env.job_name)
+    configure_s3_env.assert_called_once_with(expected_model_dir, REGION)