Skip to content

Commit 825cde1

Browse files
authored
Merge pull request #108 from ziyanli-amazon/master
Update SQSConnection to avoid race condition
2 parents adc067f + 4d4c43d commit 825cde1

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.amazonaws</groupId>
88
<artifactId>amazon-sqs-java-messaging-lib</artifactId>
9-
<version>1.0.8</version>
9+
<version>1.0.9</version>
1010
<packaging>jar</packaging>
1111
<name>Amazon SQS Java Messaging Library</name>
1212
<description>The Amazon SQS Java Messaging Library holds the Java Message Service compatible classes, that are used

src/main/java/com/amazon/sqs/javamessaging/SQSConnection.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,14 @@ public Session createSession(boolean transacted, int acknowledgeMode) throws JMS
196196
throw new JMSException("Unrecognized acknowledgeMode. Cannot create Session.");
197197
}
198198
synchronized (stateLock) {
199-
checkClosing();
199+
if (closing) {
200+
/**
201+
* SQSSession's constructor has already started a SQSSessionCallbackScheduler which should be closed
202+
* before leaving sqsSession object.
203+
*/
204+
sqsSession.close();
205+
throw new IllegalStateException("Connection is closed or closing");
206+
}
200207
sessions.add(sqsSession);
201208

202209
/**

0 commit comments

Comments
 (0)