Skip to content

Removed skeptic because of failures during cargo package. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2018
Merged

Removed skeptic because of failures during cargo package. #10

merged 1 commit into from
Nov 29, 2018

Conversation

davidbarsky
Copy link
Contributor

Description of changes:

  • We were failing to package because of some weird interaction between skeptic and workspaces. Will fix later!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davidbarsky davidbarsky requested a review from sapessi November 29, 2018 18:14
sapessi
sapessi approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@sapessi sapessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@davidbarsky davidbarsky merged commit cc96937 into master Nov 29, 2018
@nmoutschen nmoutschen deleted the remove-skeptic branch February 1, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapessi sapessi sapessi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbarsky @sapessi