Skip to content

GitHub actions #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2019
Merged

GitHub actions #165

merged 5 commits into from
Nov 16, 2019

Conversation

AnderEnder
Copy link
Contributor

Description of changes:

  • This adds GitHub actions for CI, which can replace TravisCI. A continuation of initial PR#155.
  • additionally replace deprecated usage of traits with dyn to fix the CI
  • additionally add fmt changes to fix the CI
  • nightly was added but temporary disabled because there is no direct analogue of travis ALLOW_FAILURES=1 feature

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@davidbarsky
Copy link
Contributor

Thanks for doing this! I'm happy to merge this as-is, but I'm happy to accept failures on nightly for the time being. I can merge as-is, enabling nightly in a followup PR, or you can enable nightly now—your choice!

@AnderEnder
Copy link
Contributor Author

AnderEnder commented Oct 31, 2019

I can merge as-is, enabling nightly in a followup PR, or you can enable nightly now—your choice!

@davidbarsky. I have not found a proper way to support nightly with failures yet(my current ideas are quite ugly). So my proposition is to merge it as-is. I am continuing my research to find a proper way or maybe someone else will propose it in another PR.

@davidbarsky davidbarsky merged commit 439c25f into awslabs:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants