Make sure example handlers use a structured event type #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally the request event is effectively deserialized using: let event = serde_json::from_slice<T>(&body) where `T` is the type used for the handler's event type. If this is a String then Serde will fail to deserialize the JSON input (it won't ever just be a string). Handler's should use a structured type for the event that Serde will be able to deserialize the incoming JSON event data into, so this updates the examples to use serde_json::Value.
rib
force-pushed
the
wip/rib/structured-event-types
branch
from
97296f8 to
d51560f
Compare
davidbarsky
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a documentation (and examples) tweak to consider that lambda handlers need to use a structured type for their event data since Serde will try and deserialize a JSON document into that type and that won't work with a String type which the current examples use.
By submitting this pull request