Skip to content

Commit db7b90c

Browse files
committed
Addressing feedback
1 parent feb4620 commit db7b90c

17 files changed

+425
-486
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
## Large Payload Offloading Java Common Library For AWS
22

33
The **Large Payload Offloading Java Common Library For AWS** enables you to manage payloads with Amazon S3.
4-
This is especially useful for storing and retrieving payloads with size greater than the current SQS/SNS limit of 256 KB, up to a maximum of 2 GB. Specifically, you can use this library to:
4+
For example, this is useful for storing and retrieving payloads with size greater than the current SQS/SNS limit of 256 KB, up to a maximum of 2 GB. Specifically.
5+
6+
You can use this library to:
57

68
* Specify whether payloads are always stored in Amazon S3 or only when a payload's size exceeds 256 KB.
79

pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@
4040
</properties>
4141

4242
<dependencies>
43-
<dependency>
44-
<groupId>com.amazonaws</groupId>
45-
<artifactId>aws-java-sdk-sqs</artifactId>
46-
<version>${aws-java-sdk.version}</version>
47-
</dependency>
4843
<dependency>
4944
<groupId>com.amazonaws</groupId>
5045
<artifactId>aws-java-sdk-s3</artifactId>
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package com.amazonaws.largepayloadoffloading;
2+
3+
public class Constants {
4+
/**
5+
* RESERVED_ATTRIBUTE_NAME is shared between SQSExtendedClient and SNSExtendedClient as an attribute key.
6+
* This attribute indicates that the message is a pointer to the stored payload and its value shows size of actual payload.
7+
*/
8+
public static final String RESERVED_ATTRIBUTE_NAME = "AWSOffloadedPayloadSize";
9+
}

src/main/java/com/amazonaws/largepayloadoffloading/CountingOutputStream.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,24 @@
99
* strings.
1010
*/
1111
class CountingOutputStream extends OutputStream {
12-
private long totalSize;
12+
private long totalSize;
1313

14-
@Override
15-
public void write(int b) {
16-
++totalSize;
17-
}
14+
@Override
15+
public void write(int b) {
16+
++totalSize;
17+
}
1818

19-
@Override
20-
public void write(byte[] b) {
21-
totalSize += b.length;
22-
}
19+
@Override
20+
public void write(byte[] b) {
21+
totalSize += b.length;
22+
}
2323

24-
@Override
25-
public void write(byte[] b, int offset, int len) {
26-
totalSize += len;
27-
}
24+
@Override
25+
public void write(byte[] b, int offset, int len) {
26+
totalSize += len;
27+
}
2828

29-
public long getTotalSize() {
30-
return totalSize;
31-
}
29+
public long getTotalSize() {
30+
return totalSize;
31+
}
3232
}

src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConfiguration.java

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConfigurationBase.java

Lines changed: 0 additions & 234 deletions
This file was deleted.

src/main/java/com/amazonaws/largepayloadoffloading/ExtendedClientConstants.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/main/java/com/amazonaws/largepayloadoffloading/JsonDataConverter.java

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,25 @@
1313
* object.
1414
*/
1515
class JsonDataConverter {
16+
protected final ObjectMapper objectMapper;
1617

17-
protected final ObjectMapper objectMapper;
18+
public JsonDataConverter() {
19+
this(new ObjectMapper());
20+
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
21+
objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
22+
objectMapper.enableDefaultTyping(DefaultTyping.NON_FINAL);
23+
}
1824

19-
public JsonDataConverter() {
20-
this(new ObjectMapper());
21-
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
22-
objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
23-
objectMapper.enableDefaultTyping(DefaultTyping.NON_FINAL);
24-
}
25+
public JsonDataConverter(ObjectMapper objectMapper) {
26+
this.objectMapper = objectMapper;
27+
}
2528

26-
public JsonDataConverter(ObjectMapper objectMapper) {
27-
this.objectMapper = objectMapper;
28-
}
29+
public String serializeToJson(Object obj) throws JsonProcessingException {
30+
ObjectWriter objectWriter = objectMapper.writer();
31+
return objectWriter.writeValueAsString(obj);
32+
}
2933

30-
public String serializeToJson(Object obj) throws JsonProcessingException {
31-
ObjectWriter objectWriter = objectMapper.writer();
32-
return objectWriter.writeValueAsString(obj);
33-
}
34-
35-
public <T> T deserializeFromJson(String jsonText, Class<T> objectType) throws Exception {
36-
return objectMapper.readValue(jsonText, objectType);
37-
}
34+
public <T> T deserializeFromJson(String jsonText, Class<T> objectType) throws Exception {
35+
return objectMapper.readValue(jsonText, objectType);
36+
}
3837
}

0 commit comments

Comments
 (0)