Changed add collaborator flow (#257)

* changed add collaborator flow

* showing the footer as well
but no need to click on save changes button

Author: sadakchap

src/components/FlowView/FlowView.react.js

@@ -20,6 +20,7 @@ export default class FlowView extends React.Component {
       saveState: SaveButton.States.WAITING,
       saveError: '',
     };
+    this.handleClickSaveButton = this.handleClickSaveButton.bind(this);
   }
 
   componentWillReceiveProps(props) {
@@ -58,6 +59,9 @@ export default class FlowView extends React.Component {
         saveError: '',
         changes: newChanges,
       });
+      if(key === 'collaborators'){
+        this.handleClickSaveButton();
+      }
     }
   }
 
@@ -71,6 +75,20 @@ export default class FlowView extends React.Component {
     }
   }
 
+  handleClickSaveButton() {
+    let fields = this.currentFields();
+    this.setState({ saveState: SaveButton.States.SAVING });
+    this.props.onSubmit({ changes: this.state.changes, fields, setField: this.setField, resetFields: this.resetFields }).then(() => {
+      this.setState({ saveState: SaveButton.States.SUCCEEDED });
+      this.props.afterSave({ fields, setField: this.setField, resetFields: this.resetFields });
+    }).catch(({ message, error, notice, errors = [] }) => {
+      this.setState({
+        saveState: SaveButton.States.FAILED,
+        saveError: errors.join(' ') || message || error || notice || 'An error occurred',
+      });
+    });
+  }
+
   render() {
     let {
       inProgressText,
@@ -125,18 +143,7 @@ export default class FlowView extends React.Component {
       waitingText={submitText}
       savingText={inProgressText}
       disabled={!!hasFormValidationError}
-      onClick={() => {
-        this.setState({ saveState: SaveButton.States.SAVING });
-        onSubmit({ changes, fields, setField, resetFields }).then(() => {
-          this.setState({ saveState: SaveButton.States.SUCCEEDED });
-          afterSave({ fields, setField, resetFields });
-        }).catch(({ message, error, notice, errors = [] }) => {
-          this.setState({
-            saveState: SaveButton.States.FAILED,
-            saveError: errors.join(' ') || message || error || notice || 'An error occurred',
-          });
-        });
-      }}
+      onClick={this.handleClickSaveButton.bind(this)}
     />;
 
     let footer = shouldShowFooter ? <FlowFooter
@@ -164,3 +171,7 @@ FlowView.propTypes = {
   secondaryButton: PropTypes.func.describe('Overrride the cancel button by passing a function that returns your custom node. By default, the cancel button says "Cancel" and calls resetFields().'),
   defaultFooterMessage: PropTypes.node.describe('A message for the footer when the validate message is "use default"'),
 };
+
+FlowView.defaultProps = {
+  afterSave: () => {}
+};

src/dashboard/Settings/GeneralSettings.react.js

@@ -484,7 +484,7 @@ export default class GeneralSettings extends DashboardView {
       textModal={true}>
       <span>We have removed <strong>{joinWithFinal('', this.state.removedCollaborators.map(c => c.userName || c.userEmail), ', ', ' and ')}</strong> from this app. If they had saved the master key, they may still have access via an SDK or the API. To be sure, you can reset your master key in the Keys section of app settings.</span>
     </Modal> : null;
-    let setCollaborators = (setField, unused, allCollabs) => {
+    let setCollaborators = (setField, _, allCollabs) => {
       let addedCollaborators = setDifference(allCollabs, initialFields.collaborators, compareCollaborators);
       let removedCollaborators = setDifference(initialFields.collaborators, allCollabs, compareCollaborators);
       if (addedCollaborators.length === 0 && removedCollaborators.length === 0) {
@@ -513,7 +513,7 @@ export default class GeneralSettings extends DashboardView {
           if (changes.inProduction !== undefined) {
             promiseList.push(this.context.currentApp.setInProduction(changes.inProduction));
           }
-
+          
           let removedCollaborators;
           if (changes.collaborators !== undefined) {
             let addedCollaborators = setDifference(changes.collaborators, initialFields.collaborators, compareCollaborators);