Skip to content

Commit f7b0b8a

Browse files
committed
[mlir][linalg][nfc] Update pack-dynamic-inner-tile.mlir
Following on from llvm#116373, updates "pack-dynamic-inner-tile.mlir" to use TD Ops for all transformations except for lowering to LLVM. This is an intermediate step before introducing vectorization.
1 parent 0775088 commit f7b0b8a

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
// DEFINE: -transform-interpreter -test-transform-dialect-erase-schedule |\
33
// DEFINE: mlir-opt --test-linalg-transform-patterns="test-decompose-tensor-pack"\
44
// DEFINE: --test-transform-dialect-erase-schedule \
5-
// DEFINE: -one-shot-bufferize="bufferize-function-boundaries" \
6-
// DEFINE: -buffer-deallocation-pipeline="private-function-dynamic-ownership" \
7-
// DEFINE: -cse -canonicalize -test-lower-to-llvm -o %t
5+
// DEFINE: -test-lower-to-llvm -o %t
86
// DEFINE: %{entry_point} = main
97
// DEFINE: %{run} = mlir-cpu-runner %t -e %{entry_point} -entry-point-result=void \
108
// DEFINE: -shared-libs=%mlir_runner_utils,%mlir_c_runner_utils
@@ -84,12 +82,30 @@ func.func private @pack(%A: tensor<7x16xi32>) {
8482
}
8583

8684
module @transforms attributes { transform.with_named_sequence } {
87-
transform.named_sequence @__transform_main(%module: !transform.any_op {transform.readonly}) {
85+
transform.named_sequence @__transform_main(%module: !transform.any_op {transform.consume}) {
8886
%pack = transform.structured.match ops{["tensor.pack"]} in %module : (!transform.any_op) -> !transform.any_op
8987

90-
%tiled_linalg_op_p, %loops:2 = transform.structured.tile_using_for %pack tile_sizes [1, 1]
88+
// 1. Tile so that we can decompose tensor.pack into tensor.pad,
89+
// linalg.transpose, etc (see step 2).
90+
%tiled_pack_op_p, %loops:2 = transform.structured.tile_using_for %pack tile_sizes [1, 1]
9191
: (!transform.any_op) -> (!transform.any_op, !transform.any_op, !transform.any_op)
9292

93+
// 2. Decompose the tiled Op into tensor.pad etc
94+
%func_1 = transform.get_parent_op %tiled_pack_op_p {isolated_from_above} : (!transform.any_op) -> !transform.any_op
95+
transform.apply_patterns to %func_1 {
96+
transform.apply_patterns.linalg.decompose_pack_unpack
97+
} : !transform.any_op
98+
99+
// 3. Bufferize before lowering to LLVM
100+
%bufferize = transform.bufferization.one_shot_bufferize %module
101+
{bufferize_function_boundaries=true} : (!transform.any_op) -> !transform.any_op
102+
103+
// 4. Canonicalize
104+
%func_2 = transform.structured.match ops{["func.func"]} in %bufferize : (!transform.any_op) -> !transform.op<"func.func">
105+
transform.apply_patterns to %func_2 {
106+
transform.apply_patterns.canonicalization
107+
} : !transform.op<"func.func">
108+
93109
transform.yield
94110
}
95111
}

0 commit comments

Comments
 (0)