Remove PhpCompilerAttribute and introduce failing test for attributes of PhpAttribute

Author: beberlei

Zend/tests/attributes/007_self_reflect_attribute.phpt

@@ -0,0 +1,19 @@
+--TEST--
+Attributes: attributes on PhpAttribute return itself
+--FILE--
+<?php
+
+$reflection = new \ReflectionClass(PhpAttribute::class);
+$attributes = $reflection->getAttributes();
+
+foreach ($attributes as $attribute) {
+    var_dump($attribute->getName());
+    var_dump($attribute->getArguments());
+    var_dump($attribute->newInstance());
+}
+--EXPECTF--
+string(12) "PhpAttribute"
+array(0) {
+}
+object(PhpAttribute)#3 (0) {
+}

Zend/tests/attributes/007_wrong_compiler_attributes.phpt

@@ -3,7 +3,6 @@
 #include "zend_attributes.h"
 
 ZEND_API zend_class_entry *zend_ce_php_attribute;
-ZEND_API zend_class_entry *zend_ce_php_compiler_attribute;
 
 static HashTable internal_validators;
 
@@ -14,11 +13,6 @@ void zend_attribute_validate_phpattribute(zend_attribute *attr, int target)
 	}
 }
 
-void zend_attribute_validate_phpcompilerattribute(zend_attribute *attr, int target)
-{
-	zend_error(E_COMPILE_ERROR, "The PhpCompilerAttribute can only be used by internal classes, use PhpAttribute instead");
-}
-
 ZEND_API zend_attributes_internal_validator zend_attribute_get_validator(zend_string *lcname)
 {
 	return zend_hash_find_ptr(&internal_validators, lcname);
@@ -109,10 +103,4 @@ void zend_register_attribute_ce(void)
 	zend_ce_php_attribute->ce_flags |= ZEND_ACC_FINAL;
 
 	zend_compiler_attribute_register(zend_ce_php_attribute, zend_attribute_validate_phpattribute);
-
-	INIT_CLASS_ENTRY(ce, "PhpCompilerAttribute", NULL);
-	zend_ce_php_compiler_attribute = zend_register_internal_class(&ce);
-	zend_ce_php_compiler_attribute->ce_flags |= ZEND_ACC_FINAL;
-
-	zend_compiler_attribute_register(zend_ce_php_compiler_attribute, zend_attribute_validate_phpcompilerattribute);
 }

Zend/zend_attributes.c

@@ -14,7 +14,6 @@
 BEGIN_EXTERN_C()
 
 extern ZEND_API zend_class_entry *zend_ce_php_attribute;
-extern ZEND_API zend_class_entry *zend_ce_php_compiler_attribute;
 
 typedef struct _zend_attribute {
 	zend_string *name;

Zend/zend_attributes.h

@@ -6623,7 +6623,6 @@ ZEND_METHOD(ReflectionAttribute, newInstance)
 	RETURN_ZVAL(&obj, 1, 1);
 }
 /* }}} */
-
 static const zend_function_entry reflection_ext_functions[] = { /* {{{ */
 	PHP_FE_END
 }; /* }}} */