Add tests for attributes on all elements.

Author: beberlei

Zend/tests/attributes_001.phpt

@@ -1,175 +1,168 @@
 --TEST--
-Basic attributes usage
+Basic attributes usage on all elements
 --FILE--
 <?php
-function dump_attributes($attributes) {
+class Attr {
+    public $element;
+
+    public function __construct(string $element) {
+        $this->element = $element;
+    }
+}
+class OtherAttr {}
+
+function dump_attributes($reflection) {
     $arr = [];
-    foreach ($attributes as $attribute) {
+    foreach ($reflection->getAttributes() as $attribute) {
         if (!isset($arr[$attribute->getName()])) {
             $arr[$attribute->getName()] = [];
         }
         $arr[$attribute->getName()][] = $attribute->getArguments();
     }
     var_dump($arr);
 }
-// No attributes
-function f0() {
-}
-$r = new ReflectionFunction("f0");
-dump_attributes($r->getAttributes());
 
-// Function attributes
-<<TestFunction>>
-function foo() {
-}
-$r = new ReflectionFunction("foo");
-dump_attributes($r->getAttributes());
+function f0() {}
+dump_attributes(new ReflectionFunction("f0"));
+
+<<Attr("function")>>
+function foo() {}
+dump_attributes(new ReflectionFunction("foo"));
 
 // Class attributes
-<<TestClass>>
+<<Attr("class")>>
 class Bar {
-	<<TestConst>>
+	<<Attr("const")>>
 	const C = 2;
-	<<TestProp>>
+	<<Attr("property")>>
 	public $x = 3;
 
 }
-$r = new ReflectionClass("Bar");
-dump_attributes($r->getAttributes());
-$r1 = $r->getReflectionConstant("C");
-dump_attributes($r1->getAttributes());
-$r2 = $r->getProperty("x");
-dump_attributes($r2->getAttributes());
+$reflectionClass = new ReflectionClass("Bar");
+dump_attributes($reflectionClass);
+dump_attributes($reflectionClass->getReflectionConstant("C"));
+dump_attributes($reflectionClass->getProperty("x"));
+
+$foo = <<Attr("closure")>>function () {};
+dump_attributes(new ReflectionFunction($foo));
+
+$foo = <<Attr("short closure")>>fn ($x) => $x;
+dump_attributes(new ReflectionFunction($foo));
+
+$anonClass = new <<Attr("anon class")>>class {};
+dump_attributes(new ReflectionClass($anonClass));
 
 // Multiple attributes with multiple values
-<<a1>>
-<<a2(1)>>
-<<a3(1,2)>>
+<<Attr()>>
+<<OtherAttr()>>
 function f1() {}
-$r = new ReflectionFunction("f1");
-dump_attributes($r->getAttributes());
+dump_attributes(new ReflectionFunction("f1"));
 
-// Attributes with AST
-<<a1>>
-<<a2(1+1)>>
-<<a3(1+3,2+2)>>
-<<a4(["a"=>1,"b"=>2])>>
+// multiple instances of same attribute
+<<Attr("foo")>>
+<<Attr("bar")>>
 function f2() {}
-$r = new ReflectionFunction("f2");
-dump_attributes($r->getAttributes());
-
-// Attributes with namespaces
-<<Foo\Bar>>
-function f4() {
-}
-$r = new ReflectionFunction("f4");
-dump_attributes($r->getAttributes());
+dump_attributes(new ReflectionFunction("f2"));
 ?>
 --EXPECT--
 array(0) {
 }
 array(1) {
-  ["TestFunction"]=>
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(0) {
+    array(1) {
+      [0]=>
+      string(8) "function"
     }
   }
 }
 array(1) {
-  ["TestClass"]=>
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(0) {
+    array(1) {
+      [0]=>
+      string(5) "class"
     }
   }
 }
 array(1) {
-  ["TestConst"]=>
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(0) {
+    array(1) {
+      [0]=>
+      string(5) "const"
     }
   }
 }
 array(1) {
-  ["TestProp"]=>
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(0) {
+    array(1) {
+      [0]=>
+      string(8) "property"
     }
   }
 }
-array(3) {
-  ["a1"]=>
+array(1) {
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(0) {
+    array(1) {
+      [0]=>
+      string(7) "closure"
     }
   }
-  ["a2"]=>
+}
+array(1) {
+  ["Attr"]=>
   array(1) {
     [0]=>
     array(1) {
       [0]=>
-      int(1)
+      string(13) "short closure"
     }
   }
-  ["a3"]=>
+}
+array(1) {
+  ["Attr"]=>
   array(1) {
     [0]=>
-    array(2) {
+    array(1) {
       [0]=>
-      int(1)
-      [1]=>
-      int(2)
+      string(10) "anon class"
     }
   }
 }
-array(4) {
-  ["a1"]=>
+array(2) {
+  ["Attr"]=>
   array(1) {
     [0]=>
     array(0) {
     }
   }
-  ["a2"]=>
+  ["OtherAttr"]=>
   array(1) {
     [0]=>
-    array(1) {
-      [0]=>
-      int(2)
+    array(0) {
     }
   }
-  ["a3"]=>
-  array(1) {
+}
+array(1) {
+  ["Attr"]=>
+  array(2) {
     [0]=>
-    array(2) {
+    array(1) {
       [0]=>
-      int(4)
-      [1]=>
-      int(4)
+      string(3) "foo"
     }
-  }
-  ["a4"]=>
-  array(1) {
-    [0]=>
+    [1]=>
     array(1) {
       [0]=>
-      array(2) {
-        ["a"]=>
-        int(1)
-        ["b"]=>
-        int(2)
-      }
-    }
-  }
-}
-array(1) {
-  ["Foo\Bar"]=>
-  array(1) {
-    [0]=>
-    array(0) {
+      string(3) "bar"
     }
   }
 }