Renamed const to IS_INSTANCE to be consistent with getMethods() filter.

Author: kooldev

Zend/tests/attributes/filter.phpt

@@ -26,27 +26,27 @@ class A2 implements Base { }
 class A3 extends A2 { }
 
 $ref = new \ReflectionFunction(<<A1>> <<A2>> <<A5>> function () { });
-$attr = $ref->getAttributes(\stdClass::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+$attr = $ref->getAttributes(\stdClass::class, \ReflectionAttribute::IS_INSTANCEOF);
 var_dump(count($attr));
 print_r(array_map(fn ($a) => $a->getName(), $attr));
 
 $ref = new \ReflectionFunction(<<A1>> <<A2>> function () { });
-$attr = $ref->getAttributes(A1::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+$attr = $ref->getAttributes(A1::class, \ReflectionAttribute::IS_INSTANCEOF);
 var_dump(count($attr));
 print_r(array_map(fn ($a) => $a->getName(), $attr));
 
 $ref = new \ReflectionFunction(<<A1>> <<A2>> function () { });
-$attr = $ref->getAttributes(Base::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+$attr = $ref->getAttributes(Base::class, \ReflectionAttribute::IS_INSTANCEOF);
 var_dump(count($attr));
 print_r(array_map(fn ($a) => $a->getName(), $attr));
 
 $ref = new \ReflectionFunction(<<A1>> <<A2>> <<A3>> function () { });
-$attr = $ref->getAttributes(A2::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+$attr = $ref->getAttributes(A2::class, \ReflectionAttribute::IS_INSTANCEOF);
 var_dump(count($attr));
 print_r(array_map(fn ($a) => $a->getName(), $attr));
 
 $ref = new \ReflectionFunction(<<A1>> <<A2>> <<A3>> function () { });
-$attr = $ref->getAttributes(Base::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+$attr = $ref->getAttributes(Base::class, \ReflectionAttribute::IS_INSTANCEOF);
 var_dump(count($attr));
 print_r(array_map(fn ($a) => $a->getName(), $attr));
 
@@ -63,7 +63,7 @@ try {
 $ref = new \ReflectionFunction(function () { });
 
 try {
-	$ref->getAttributes(SomeMissingClass::class, \ReflectionAttribute::FILTER_INSTANCEOF);
+	$ref->getAttributes(SomeMissingClass::class, \ReflectionAttribute::IS_INSTANCEOF);
 } catch (\Error $e) {
 	var_dump('ERROR 2', $e->getMessage());
 }

ext/reflection/php_reflection.c

@@ -111,7 +111,7 @@ PHPAPI zend_class_entry *reflection_attribute_ptr;
 #define REGISTER_REFLECTION_CLASS_CONST_LONG(class_name, const_name, value) \
 	zend_declare_class_constant_long(reflection_ ## class_name ## _ptr, const_name, sizeof(const_name)-1, (zend_long)value);
 
-#define REFLECTION_ATTRIBUTE_FILTER_INSTANCEOF (1 << 1)
+#define REFLECTION_ATTRIBUTE_IS_INSTANCEOF (1 << 1)
 
 /* {{{ Object structure */
 
@@ -1224,12 +1224,12 @@ static void reflect_attributes(INTERNAL_FUNCTION_PARAMETERS, HashTable *attribut
 		RETURN_THROWS();
 	}
 
-	if (flags & ~REFLECTION_ATTRIBUTE_FILTER_INSTANCEOF) {
+	if (flags & ~REFLECTION_ATTRIBUTE_IS_INSTANCEOF) {
 		zend_throw_error(NULL, "Invalid attribute filter flag specified");
 		RETURN_THROWS();
 	}
 
-	if (name && (flags & REFLECTION_ATTRIBUTE_FILTER_INSTANCEOF)) {
+	if (name && (flags & REFLECTION_ATTRIBUTE_IS_INSTANCEOF)) {
 		if (NULL == (base = zend_lookup_class(name))) {
 			if (!EG(exception)) {
 				zend_throw_error(NULL, "Class '%s' not found", ZSTR_VAL(name));
@@ -7145,7 +7145,7 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
 	_reflection_entry.ce_flags |= ZEND_ACC_FINAL;
 	reflection_attribute_ptr = zend_register_internal_class(&_reflection_entry);
 
-	REGISTER_REFLECTION_CLASS_CONST_LONG(attribute, "FILTER_INSTANCEOF", REFLECTION_ATTRIBUTE_FILTER_INSTANCEOF);
+	REGISTER_REFLECTION_CLASS_CONST_LONG(attribute, "IS_INSTANCEOF", REFLECTION_ATTRIBUTE_IS_INSTANCEOF);
 
 	REFLECTION_G(key_initialized) = 0;