Deprecate get_height

This deprecates `get_height` to improve alignment with the Esplora API.

Author: tnull

src/async.rs

@@ -113,6 +113,10 @@ impl AsyncClient {
         Ok(Some(resp.error_for_status()?.json().await?))
     }
 
+    #[deprecated(
+        since = "0.1.2",
+        note = "Deprecated to improve alignment with Esplora API. Users should use `get_block_hash` and `get_header_by_hash` methods directly."
+    )]
     /// Get a [`BlockHeader`] given a particular block height.
     pub async fn get_header(&self, block_height: u32) -> Result<BlockHeader, Error> {
         let block_hash = self.get_block_hash(block_height).await?;

src/blocking.rs

@@ -127,6 +127,10 @@ impl BlockingClient {
     }
 
     /// Get a [`BlockHeader`] given a particular block height.
+    #[deprecated(
+        since = "0.1.2",
+        note = "Deprecated to improve alignment with Esplora API. Users should use `get_block_hash` and `get_header_by_hash` methods directly."
+    )]
     pub fn get_header(&self, block_height: u32) -> Result<BlockHeader, Error> {
         let block_hash = self.get_block_hash(block_height)?;
         self.get_header_by_hash(&block_hash)