lint code + remove useless patches

Author: zoedberg

lightning/Cargo.toml

@@ -81,8 +81,3 @@ criterion = { version = "0.4", optional = true, default-features = false }
 
 [target.'cfg(taproot)'.dependencies]
 musig2 = { git = "https://github.com/arik-so/rust-musig2", rev = "27797d7" }
-
-[patch.crates-io]
-commit_verify = { path = "../../client_side_validation/commit_verify" }
-rgb-std = { path = "../../rgb-wallet/std" }
-rgb-wallet = { path = "../../rgb-wallet" }

lightning/src/ln/chan_utils.rs

@@ -1733,7 +1733,7 @@ impl<'a> TrustedCommitmentTransaction<'a> {
 			assert!(this_htlc.transaction_output_index.is_some());
 			let mut htlc_tx = build_htlc_transaction(&txid, inner.feerate_per_kw, channel_parameters.contest_delay(), &this_htlc, &self.channel_type_features, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
 			if inner.is_colored() {
-				if let Err(_e) = color_htlc(&mut htlc_tx, &this_htlc, &ldk_data_dir) {
+				if let Err(_e) = color_htlc(&mut htlc_tx, this_htlc, ldk_data_dir) {
 					return Err(());
 				}
 			}
@@ -1764,7 +1764,7 @@ impl<'a> TrustedCommitmentTransaction<'a> {
 			&self.channel_type_features, &keys.broadcaster_delayed_payment_key, &keys.revocation_key
 		);
 		if self.inner.is_colored() {
-			color_htlc(&mut htlc_tx, &this_htlc, &ldk_data_dir).expect("successful htlc tx coloring");
+			color_htlc(&mut htlc_tx, this_htlc, ldk_data_dir).expect("successful htlc tx coloring");
 		}
 		htlc_tx
 	}

lightning/src/rgb_utils/mod.rs

@@ -132,7 +132,7 @@ pub fn write_rgb_transfer_info(path: &PathBuf, info: &TransferInfo) {
 	fs::write(path, serialized_info).expect("able to write transfer info file")
 }
 
-fn counterparty_output_index(outputs: &Vec<TxOut>, channel_type_features: &ChannelTypeFeatures, payment_key: &PublicKey) -> Option<usize> {
+fn counterparty_output_index(outputs: &[TxOut], channel_type_features: &ChannelTypeFeatures, payment_key: &PublicKey) -> Option<usize> {
 	let counterparty_payment_script = get_counterparty_payment_script(channel_type_features, payment_key);
 	outputs.iter().enumerate()
 		.find(|(_, out)| out.script_pubkey == counterparty_payment_script)
@@ -530,7 +530,7 @@ pub fn get_rgb_channel_info(channel_id: &ChannelId, ldk_data_dir: &Path) -> (Rgb
 }
 
 /// Whether the channel data for a channel exist
-pub fn is_channel_rgb(channel_id: &ChannelId, ldk_data_dir: &PathBuf) -> bool {
+pub fn is_channel_rgb(channel_id: &ChannelId, ldk_data_dir: &Path) -> bool {
 	ldk_data_dir.join(channel_id.to_hex()).exists()
 }
 
@@ -681,7 +681,7 @@ pub(crate) fn update_rgb_channel_amount(channel_id: &ChannelId, rgb_offered_htlc
 }
 
 /// Whether the payment is colored
-pub(crate) fn is_payment_rgb(ldk_data_dir: &PathBuf, payment_hash: &PaymentHash) -> bool {
+pub(crate) fn is_payment_rgb(ldk_data_dir: &Path, payment_hash: &PaymentHash) -> bool {
 	ldk_data_dir.join(hex::encode(payment_hash.0)).exists()
 }
 

lightning/src/sign/mod.rs

@@ -1256,7 +1256,7 @@ impl EcdsaChannelSigner for InMemorySigner {
 			let chan_type = &channel_parameters.channel_type_features;
 			let mut htlc_tx = chan_utils::build_htlc_transaction(&commitment_txid, commitment_tx.feerate_per_kw(), holder_selected_contest_delay, htlc, chan_type, &keys.broadcaster_delayed_payment_key, &keys.revocation_key);
 			if commitment_tx.is_colored() {
-				if let Err(_e) = color_htlc(&mut htlc_tx, &htlc, &self.ldk_data_dir) {
+				if let Err(_e) = color_htlc(&mut htlc_tx, htlc, &self.ldk_data_dir) {
 					return Err(())
 				}
 			}