Adjust TargetRefs group validation and add MinItems validation

Author: bjee19

apis/v1alpha1/observabilitypolicy_types.go

@@ -47,6 +47,7 @@ type ObservabilityPolicySpec struct {
 	// Objects must be in the same namespace as the policy.
 	// Support: HTTPRoute, GRPCRoute.
 	//
+	// +kubebuilder:validation:MinItems=1
 	// +kubebuilder:validation:MaxItems=16
 	// +kubebuilder:validation:XValidation:message="TargetRef Kind must be: HTTPRoute or GRPCRoute",rule="(self.exists(t, t.kind=='HTTPRoute') || self.exists(t, t.kind=='GRPCRoute'))"
 	// +kubebuilder:validation:XValidation:message="TargetRef Group must be gateway.networking.k8s.io.",rule="self.all(t, t.group=='gateway.networking.k8s.io')"

apis/v1alpha1/upstreamsettingspolicy_types.go

@@ -56,8 +56,8 @@ type UpstreamSettingsPolicySpec struct {
 	// Support: Service
 	//
 	// +kubebuilder:validation:MaxItems=16
-	// +kubebuilder:validation:XValidation:message="TargetRefs Kind must be: Service",rule="self.exists(t, t.kind=='Service')"
-	// +kubebuilder:validation:XValidation:message="TargetRefs Group must be gateway.networking.k8s.io.",rule="self.all(t, t.group=='gateway.networking.k8s.io')"
+	// +kubebuilder:validation:XValidation:message="TargetRefs Kind must be: Service",rule="self.all(t, t.kind=='Service')"
+	// +kubebuilder:validation:XValidation:message="TargetRefs Group must be core.",rule="self.exists(t, t.group=='') || self.exists(t, t.group=='core')"
 	//nolint:lll
 	TargetRefs []gatewayv1alpha2.LocalPolicyTargetReference `json:"targetRefs"`
 }

config/crd/bases/gateway.nginx.org_upstreamsettingspolicies.yaml

@@ -123,9 +123,9 @@ spec:
                 type: array
                 x-kubernetes-validations:
                 - message: 'TargetRefs Kind must be: Service'
-                  rule: self.exists(t, t.kind=='Service')
-                - message: TargetRefs Group must be gateway.networking.k8s.io.
-                  rule: self.all(t, t.group=='gateway.networking.k8s.io')
+                  rule: self.all(t, t.kind=='Service')
+                - message: TargetRefs Group must be core.
+                  rule: self.exists(t, t.group=='') || self.exists(t, t.group=='core')
               zoneSize:
                 description: |-
                   ZoneSize is the size of the shared memory zone used by the upstream. This memory zone is used to share