Skip to content

Commit 5bf89a1

Browse files
committed
[LTOCodeGenerator] Reduce code duplication. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@279514 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 9cbe8af commit 5bf89a1

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

include/llvm/LTO/legacy/LTOCodeGenerator.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ struct LTOCodeGenerator {
7777
/// Resets \a HasVerifiedInput.
7878
void setModule(std::unique_ptr<LTOModule> M);
7979

80+
void setAsmUndefinedRefs(struct LTOModule *);
8081
void setTargetOptions(const TargetOptions &Options);
8182
void setDebugInfo(lto_debug_model);
8283
void setCodePICModel(Optional<Reloc::Model> Model) { RelocModel = Model; }

lib/LTO/LTOCodeGenerator.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,18 @@ void LTOCodeGenerator::initializeLTOPasses() {
130130
initializeCFGSimplifyPassPass(R);
131131
}
132132

133+
void LTOCodeGenerator::setAsmUndefinedRefs(LTOModule *Mod) {
134+
const std::vector<const char *> &undefs = Mod->getAsmUndefinedRefs();
135+
for (int i = 0, e = undefs.size(); i != e; ++i)
136+
AsmUndefinedRefs[undefs[i]] = 1;
137+
}
138+
133139
bool LTOCodeGenerator::addModule(LTOModule *Mod) {
134140
assert(&Mod->getModule().getContext() == &Context &&
135141
"Expected module in same context");
136142

137143
bool ret = TheLinker->linkInModule(Mod->takeModule());
138-
139-
const std::vector<const char *> &undefs = Mod->getAsmUndefinedRefs();
140-
for (int i = 0, e = undefs.size(); i != e; ++i)
141-
AsmUndefinedRefs[undefs[i]] = 1;
144+
setAsmUndefinedRefs(Mod);
142145

143146
// We've just changed the input, so let's make sure we verify it.
144147
HasVerifiedInput = false;
@@ -154,10 +157,7 @@ void LTOCodeGenerator::setModule(std::unique_ptr<LTOModule> Mod) {
154157

155158
MergedModule = Mod->takeModule();
156159
TheLinker = make_unique<Linker>(*MergedModule);
157-
158-
const std::vector<const char*> &Undefs = Mod->getAsmUndefinedRefs();
159-
for (int I = 0, E = Undefs.size(); I != E; ++I)
160-
AsmUndefinedRefs[Undefs[I]] = 1;
160+
setAsmUndefinedRefs(&*Mod);
161161

162162
// We've just changed the input, so let's make sure we verify it.
163163
HasVerifiedInput = false;

0 commit comments

Comments
 (0)