Skip to content

Commit 005e4b7

Browse files
committed
fixup: space only tests and looser regex
1 parent cabe20b commit 005e4b7

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

clang/test/AST/HLSL/pch.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
// Make sure PCH works by using function declared in PCH header and declare a RWBuffer in current file.
55
// CHECK:FunctionDecl 0x[[FOO:[0-9a-f]+]] <{{.*}}:2:1, line:4:1> line:2:8 imported used foo 'float2 (float2, float2)'
6-
// CHECK:VarDecl 0x{{[0-9a-f]+}} <{{.*}}:7:1, col:23> col:23 Buffer 'hlsl::RWBuffer<float>'
6+
// CHECK:VarDecl 0x{{[0-9a-f]+}} <{{.*}}:{{[0-9]+}}:1, col:23> col:23 Buffer 'hlsl::RWBuffer<float>'
77
hlsl::RWBuffer<float> Buffer;
88

99
float2 bar(float2 a, float2 b) {

clang/test/AST/HLSL/pch_hlsl_buffer.hlsl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ float foo() {
1414
}
1515

1616
// Make sure cbuffer/tbuffer works for PCH.
17-
// CHECK: HLSLBufferDecl {{.*}} line:4:9 imported <undeserialized declarations> cbuffer A
17+
// CHECK: HLSLBufferDecl {{.*}} line:{{[0-9]+}}:9 imported <undeserialized declarations> cbuffer A
1818
// CHECK-NEXT: HLSLResourceClassAttr {{.*}} Implicit CBuffer
1919
// CHECK-NEXT: VarDecl 0x[[A:[0-9a-f]+]] {{.*}} imported used a 'hlsl_constant float'
2020
// CHECK-NEXT: CXXRecordDecl {{.*}} imported implicit <undeserialized declarations> struct __cblayout_A definition
2121
// CHECK: FieldDecl {{.*}} imported a 'float'
2222

23-
// CHECK: HLSLBufferDecl {{.*}} line:8:9 imported <undeserialized declarations> tbuffer B
23+
// CHECK: HLSLBufferDecl {{.*}} line:{{[0-9]+}}:9 imported <undeserialized declarations> tbuffer B
2424
// CHECK-NEXT: HLSLResourceClassAttr {{.*}} Implicit SRV
2525
// CHECK-NEXT: VarDecl 0x[[B:[0-9a-f]+]] {{.*}} imported used b 'hlsl_constant float'
2626
// CHECK-NEXT: CXXRecordDecl 0x{{[0-9a-f]+}} {{.*}} imported implicit <undeserialized declarations> struct __cblayout_B definition
2727
// CHECK: FieldDecl 0x{{[0-9a-f]+}} {{.*}} imported b 'float'
2828

29-
// CHECK-NEXT: FunctionDecl {{.*}} line:12:7 imported foo 'float ()'
29+
// CHECK-NEXT: FunctionDecl {{.*}} line:{{[0-9]+}}:7 imported foo 'float ()'
3030
// CHECK-NEXT: CompoundStmt {{.*}}
3131
// CHECK-NEXT: ReturnStmt {{.*}}
3232
// CHECK-NEXT: BinaryOperator {{.*}} 'float' '+'

clang/test/AST/HLSL/pch_with_buf.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// Make sure buffer defined in PCH works.
77
// CHECK:VarDecl 0x{{[0-9a-f]+}} <line:6:1, col:17> col:17 imported Buf 'RWBuffer<float>'
88
// Make sure declare a RWBuffer in current file works.
9-
// CHECK:VarDecl 0x{{[0-9a-f]+}} <{{.*}}:10:1, col:23> col:23 Buf2 'hlsl::RWBuffer<float>'
9+
// CHECK:VarDecl 0x{{[0-9a-f]+}} <{{.*}}:{{[0-9]+}}:1, col:23> col:23 Buf2 'hlsl::RWBuffer<float>'
1010
hlsl::RWBuffer<float> Buf2;
1111

1212
float2 bar(float2 a, float2 b) {

clang/test/SemaHLSL/resource_binding_implicit.hlsl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ RWBuffer<int> c;
1414
// No warning - explicit binding.
1515
RWBuffer<float> d : register(u0);
1616

17+
// No warning - explicit binding.
18+
RWBuffer<float> dd : register(space1);
19+
20+
// No warning - explicit binding.
21+
RWBuffer<float> ddd : register(u3, space4);
22+
1723
struct S { int x; };
1824
// expected-warning@+1 {{resource has implicit register binding}}
1925
StructuredBuffer<S> e;

0 commit comments

Comments
 (0)