fix(BOffcanvas): remove deprecated property and aria-label for BButton.

Author: phlegx

packages/bootstrap-vue-next/src/components/BOffcanvas/BOffcanvas.vue

@@ -39,7 +39,7 @@
                 </BButton>
                 <BCloseButton
                   v-else
-                  aria-label="headerCloseLabel"
+                  :aria-label="headerCloseLabel"
                   v-bind="headerCloseAttrs"
                   @click="hide('close')"
                 />
@@ -111,7 +111,6 @@ const props = withDefaults(
     headerClass?: string
     headerCloseClass?: ClassValue
     headerCloseLabel?: string
-    headerCloseWhite?: Booleanish
     headerCloseVariant?: ButtonVariant | null
     bodyClass?: string
     footerClass?: string
@@ -137,7 +136,6 @@ const props = withDefaults(
     headerClass: undefined,
     headerCloseClass: undefined,
     headerCloseLabel: 'Close',
-    headerCloseWhite: false,
     headerCloseVariant: 'secondary',
     bodyClass: undefined,
     footerClass: undefined,
@@ -234,7 +232,6 @@ const headerCloseClasses = computed(() => [
 ])
 const headerCloseAttrs = computed(() => ({
   variant: hasHeaderCloseSlot.value ? props.headerCloseVariant : undefined,
-  white: !hasHeaderCloseSlot.value ? props.headerCloseWhite : undefined,
   class: headerCloseClasses.value,
 }))
 

packages/bootstrap-vue-next/src/components/BOffcanvas/offcanvas.spec.ts

@@ -188,15 +188,6 @@ describe.skip('offcanvas', () => {
     expect($closebutton.classes()).toContain('foobar')
   })
 
-  it('first child div child BCloseButton has class when prop headerCloseWhite', () => {
-    const wrapper = mount(BOffcanvas, {
-      props: {headerCloseWhite: true},
-    })
-    const [, $div] = wrapper.findAll('div')
-    const $closebutton = $div.getComponent(BCloseButton)
-    expect($closebutton.classes()).toContain('btn-close-white')
-  })
-
   it('first child div child BCloseButton has not variant class when headerCloseVariant', () => {
     const wrapper = mount(BOffcanvas, {
       props: {headerCloseVariant: 'warning'},
@@ -206,25 +197,6 @@ describe.skip('offcanvas', () => {
     expect($closebutton.classes()).not.toContain('btn-warning')
   })
 
-  it('first child div child BButton has prop ariaLabel to be default close', () => {
-    const wrapper = mount(BOffcanvas, {
-      slots: {'header-close': 'foobar'},
-    })
-    const [, $div] = wrapper.findAll('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.props('ariaLabel')).toBe('Close')
-  })
-
-  it('first child div child BButton has prop ariaLabel to be prop headerCloseLabel', () => {
-    const wrapper = mount(BOffcanvas, {
-      props: {headerCloseLabel: 'foobar'},
-      slots: {'header-close': 'foobar'},
-    })
-    const [, $div] = wrapper.findAll('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.props('ariaLabel')).toBe('foobar')
-  })
-
   it('first child div child BButton has class when prop headerCloseClass', () => {
     const wrapper = mount(BOffcanvas, {
       props: {headerCloseClass: 'foobar'},
@@ -235,16 +207,6 @@ describe.skip('offcanvas', () => {
     expect($bbutton.classes()).toContain('foobar')
   })
 
-  it('first child div child BButton has class when prop headerCloseWhite', () => {
-    const wrapper = mount(BOffcanvas, {
-      props: {headerCloseWhite: true},
-      slots: {'header-close': 'foobar'},
-    })
-    const [, $div] = wrapper.findAll('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.classes()).not.toContain('btn-close-white')
-  })
-
   it('first child div child BButton has variant class when headerCloseVariant', () => {
     const wrapper = mount(BOffcanvas, {
       props: {headerCloseVariant: 'warning'},