Error type in callback

Yash Ladha · Yash Ladha · commit 07aa1cbf5cfa · 2020-01-24T15:36:09.000+05:30
diff --git a/index.d.ts b/index.d.ts
@@ -19,9 +19,11 @@ declare module "browserstack-local" {
     [key: string]: string | boolean;
   }
 
+  type LocalOptions = Partial<Options>;
+
   class Local {
-    start(options: Partial<Options>, callback: (error?: Error) => void): void;
+    start(options: LocalOptions, callback: (error?: Error) => void): void;
     isRunning(): boolean;
-    stop(callback: () => void): void;
+    stop(callback: (error?: Error) => void): void;
   }
 }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "browserstack-local",
-  "version": "1.4.5",
+  "version": "1.4.6",
   "description": "Nodejs bindings for BrowserStack Local",
   "engine": "^0.10.44",
   "main": "index.js",

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,11 @@ declare module "browserstack-local" {`
`19`	`19`	`[key: string]: string \| boolean;`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ type LocalOptions = Partial<Options>;`
	`23`	`+`
`22`	`24`	`class Local {`
`23`		`- start(options: Partial<Options>, callback: (error?: Error) => void): void;`
	`25`	`+ start(options: LocalOptions, callback: (error?: Error) => void): void;`
`24`	`26`	`isRunning(): boolean;`
`25`		`- stop(callback: () => void): void;`
	`27`	`+ stop(callback: (error?: Error) => void): void;`
`26`	`28`	`}`
`27`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "browserstack-local",`
`3`		`- "version": "1.4.5",`
	`3`	`+ "version": "1.4.6",`
`4`	`4`	`"description": "Nodejs bindings for BrowserStack Local",`
`5`	`5`	`"engine": "^0.10.44",`
`6`	`6`	`"main": "index.js",`